CommentFileSizeAuthor
#8 add_seperator_ending-2666010-8.patch2.88 KBtatarbj
#4 add_seperator_ending-2666010-4.patch3.31 KBghuygens

Comments

Chimos created an issue. See original summary.

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented

Sounds like a reasonable feature request. I'm happy to except a patch for it. If you don't want to create a patch, you could accomplish this with CSS ::after.

~Greg

Chimos’s picture

Chimos commented

Thanks for your answer. Sadly, I don't have enough time / knowledge to make this patch right now. I will let you know if I finally do it.

Thanks for the ::after tip. Although it would be better to define the separator character only in one place, this workaround will let me keep using the module, since it was the only problem I had.

Cheers

ghuygens’s picture

ghuygens commented
StatusFileSize
new add_seperator_ending-2666010-4.patch3.31 KB
ghuygens’s picture

ghuygens commented
Issue summary: View changes
Status: Active » Needs review

to review

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented
Issue summary: View changes

Patch looks great. Thanks!

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented
Status: Needs review » Reviewed & tested by the community
tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new add_seperator_ending-2666010-8.patch2.88 KB

Hi all,
because of the planned new release i've rerolled and a bit recreate the logic of this patch, that needs to be reviewed again, please.
Cheers,
Balazs.

  • Greg Boggs committed 14387e1 on 7.x-2.x authored by tatarbj 
    Issue #2666010 by ghuygens, tatarbj: Checkbox to keep the segments...
  • tatarbj authored 3078ea8 on 7.x-2.x
    Issue #2666010 by ghuygens, tatarbj: Checkbox to keep the segments...
tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
Status: Needs review » Reviewed & tested by the community
tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.