The module doesn't uninstall the registration_role_roles variable correctly as I think the hook implementation is erroneously using hook_delete instead of hook_uninstall. I also had to convert the install file using dos2unix as the line endings were showing as ^M in the original diff. Patch forthcoming.

CommentFileSizeAuthor
#2 registration_role-uninstall-hook-incorrectly-named-2665590-2.patch647 bytesbadjava

Comments

badjava created an issue. See original summary.

badjava’s picture

badjava commented
StatusFileSize
new registration_role-uninstall-hook-incorrectly-named-2665590-2.patch647 bytes

Here is the patch. Because of the file conversion, the entire contents of the file are being replaced.

badjava’s picture

badjava commented
Status: Active » Needs review
aprogs’s picture

aprogs commented

Confirming the bug, the variable does not get deleted.

Hook hook_node_delete() responds to node deletion, the correct hook is hook_uninstall() as @badjava suggested.

  • mlncn committed 58638c7 on 7.x-1.x authored by badjava 
    Issue #2665590 by badjava: Uninstall hook incorrectly named
mlncn’s picture

mlncn commented
Status: Needs review » Reviewed & tested by the community

Thanks, brought this in. How has this been working before is my question— ah hook_delete would only be called if registration_role provided a custom node type.

mlncn’s picture

mlncn commented
Status: Reviewed & tested by the community » Fixed

This is in release 7.x-1.2. Thank you badjava! And sorry for the delay.

mlncn’s picture

mlncn commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.