Closed (fixed)
Project:
Metatag
Version:
8.x-1.x-dev
Component:
Open Graph
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
6 Feb 2016 at 17:40 UTC
Updated:
26 Oct 2016 at 12:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
damienmckennaComment #3
damienmckennaComment #4
damienmckennaComment #5
it-cruDoes this issue also includes meta tags like article:publisher, article:published_time and so on from http://ogp.me/ ?
Comment #6
damienmckennaThe idea is to add anything listed for the D7 version of Metatag that's not already in the D8 version, so probably.
Comment #7
it-cruPatch for article: xyz meta tags ported from current metatag D7 1.14 module. Works fine on first test for me. Labels, descriptions and field weights are taken from the 7.x-1.14 version. Hope file, class and ID namings are correct for D8.
Comment #8
damienmckennaComment #10
damienmckennaUpdated to add the new 'secure' attribute.
Comment #13
damienmckennaDoh!
Comment #15
damienmckennaCommitted. Putting this back to 'needs work' as there are more to go.
Comment #16
damienmckennaComment #17
it-cruIf the last patch was flawless (exclude the missing new 'secure' attribute), I can gladly prepare patches for the outstanding OG metatags.
Comment #18
damienmckennaIT-Cru: Any help would be appreciated.
Comment #19
damienmckennaComment #20
damienmckennaComment #21
damienmckennaNot putting this into beta10.
Comment #22
dawehnerHere are some additional ones coming from #2799949: A couple of additional metatags
Comment #23
damienmckennaThanks @dawehner.
This adds the new tags to the module's tests suite, and adds the config schema records.
Comment #25
damienmckennaCommitted. Lets do new issues for any additional OG meta tags.
Comment #26
dawehnerNice, thank you for adding them! One thing I'm a bit confused about: Why does this needs to be a label, do you want to have different values per language?
Comment #27
damienmckennaYes, the goal is to allow each tag to be translated as there will be some sites that have different versions of the same video depending upon the language.