Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Add the remaining OG meta tags to the D8 branch, including the Products ones.
Comment | File | Size | Author |
---|---|---|---|
#23 | metatag-n2663974-23.interdiff.txt | 2.61 KB | DamienMcKenna |
#23 | metatag-n2663974-23.patch | 7.08 KB | DamienMcKenna |
| |||
#13 | metatag-n2692117-11.patch | 8.53 KB | DamienMcKenna |
#10 | metatag-n2692117-10.patch | 0 bytes | DamienMcKenna |
Comments
Comment #2
DamienMcKennaComment #3
DamienMcKennaComment #4
DamienMcKennaComment #5
IT-CruDoes this issue also includes meta tags like article:publisher, article:published_time and so on from http://ogp.me/ ?
Comment #6
DamienMcKennaThe idea is to add anything listed for the D7 version of Metatag that's not already in the D8 version, so probably.
Comment #7
IT-CruPatch for article: xyz meta tags ported from current metatag D7 1.14 module. Works fine on first test for me. Labels, descriptions and field weights are taken from the 7.x-1.14 version. Hope file, class and ID namings are correct for D8.
Comment #8
DamienMcKennaComment #10
DamienMcKennaUpdated to add the new 'secure' attribute.
Comment #13
DamienMcKennaDoh!
Comment #15
DamienMcKennaCommitted. Putting this back to 'needs work' as there are more to go.
Comment #16
DamienMcKennaComment #17
IT-CruIf the last patch was flawless (exclude the missing new 'secure' attribute), I can gladly prepare patches for the outstanding OG metatags.
Comment #18
DamienMcKennaIT-Cru: Any help would be appreciated.
Comment #19
DamienMcKennaComment #20
DamienMcKennaComment #21
DamienMcKennaNot putting this into beta10.
Comment #22
dawehnerHere are some additional ones coming from #2799949: A couple of additional metatags
Comment #23
DamienMcKennaThanks @dawehner.
This adds the new tags to the module's tests suite, and adds the config schema records.
Comment #25
DamienMcKennaCommitted. Lets do new issues for any additional OG meta tags.
Comment #26
dawehnerNice, thank you for adding them! One thing I'm a bit confused about: Why does this needs to be a label, do you want to have different values per language?
Comment #27
DamienMcKennaYes, the goal is to allow each tag to be translated as there will be some sites that have different versions of the same video depending upon the language.