After creating a test order I went to view order invoice from Invoice tab in Order admin panel. There were store, billing & shipping address, but they were not render properly. I found HTML Tag <br> into the address text and both were one line. Same problem in Invoice Print Section.
Problem issue's image attached.
According to our order router I found a template file called uc-order-invoice.html.twig
I found the following variables for store, billing & shipping address-
{{ store_address }}
{{ order_billing_address }}
{{ order_shipping_address }}
I think, we should fix the render issues.
I am new, but I think, for this issue we can use raw twig filter.
{{ store_address|raw }}
{{ order_billing_address|raw }}
{{ order_shipping_address|raw }}
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | invoice-br.patch | 1.37 KB | tr |
| #2 | after-applying-patch.png | 26.19 KB | imrancluster |
| #2 | store-billing-shipping-address-render-problem-2663130-2.patch | 1.4 KB | imrancluster |
| store-billing-shipping-address-render-problem.png | 24.51 KB | imrancluster |
Comments
Comment #2
imrancluster commentedHere is a patch
But don't forgot to clear cache after applying this patch if your twig debug is enable.
Also uploaded a image after applying this patch in 8.x-4.x branch.
Comment #3
tr commentedYes, that's the one place where escaped HTML is still showing in 8.x-4.x that I know of. While your solution works I would rather deal with this issue another way so we don't have to circumvent Twig autoescaping.
The basic problem is we haven't rewritten the template preprocess function and the templates for the invoices. In the preprocess function, the Address objects gets implicitly converted to strings when they are put in the address variables (store_address etc). The conversion is through the __toString() method on Address, which adds those
<br>. Twig then autoescapes the<br>because<br>is not on the list of allowed tags.What I'd like to do is to re-write the entire invoice template and theme functions so the invoice uses the main store theme to render an invoice, rather than pre-set colors and fonts etc. that were chosen for Ubercart back in the D5 days. Our current invoice is ugly and doesn't respect the site's theme.
If you can work on this that would be a great help!
Comment #4
imrancluster commentedI am very new for Drupal 8, but I am really interested to work.
I already reply your Email.
Comment #6
tr commentedThe store address was fixed by the commit in #5, this should fix the billing and shipping addresses:
Comment #7
tr commentedCommitted.