Update JS Example to meet coding standards [#2662908]

Problem/Motivation

The JS Example doesn't meet Drupal coding standards according to phpcs.

Proposed resolution

Make the suggestions by phpcs.

Comment	File	Size	Author
#2	update_js_example_to-2662908-2.patch	9.12 KB	jlbellido
#2	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.1 94 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

4 February 2016 at 20:58

jlbellido created an issue. See original summary.

Comment #2

jlbellido

Spanish

CreditAttribution: jlbellido at Cocomore AG commented 4 February 2016 at 21:02

Status:

Active

» Needs review

File	Size
update_js_example_to-2662908-2.patch	9.12 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.1 94 pass

Add a new patch for solving all errors found by CS at the JS example.

Thanks!

Comment #3

3 February 2016 at 18:06

Mile23 committed 97c66b1 on authored by jlbellido

Issue #2662908 by jlbellido: Update JS Example to meet coding standards

Comment #4

Mile23

English

Seattle, WA

CreditAttribution: Mile23 as a volunteer commented 9 February 2016 at 21:05

Status:

Needs review

» Fixed

+++ b/js_example/src/Controller/JsExampleController.php
@@ -23,16 +23,27 @@ class JsExampleController extends ControllerBase {
+    $build['content'] = [
+      'first_line' => [
+        '#prefix' => '<p>',
+        '#markup' => 'Drupal includes jQuery and jQuery UI.',
+        '#suffix' => '</p>',
+      ],

So I totally get why you did this, and the reasons are all good. It's a little bit of overkill, however, especially given that we have the {% trans %} tag in twig. So we'll commit this and then move over to templates later.

Committed and fixed. Thanks!