Steps to reproduce:

  1. Create a webform
  2. Go to form components

Result:

  • drag and drop icon is visible
  • Link "Show row weights" is visible
  • Column "Required" is hidden
  • Column "Weight" is visible
  • Class "tabledrag-hide" is on the wrong th tag

Steps to reproduce:

  1. Click "Show row weights"

Result:

  • drag and drop icon is hidden
  • Link "Hide row weights" is visible
  • Column "Required" is visible
  • Column "Weight" is visible
  • Class "tabledrag-hide" is on the wrong th tag
CommentFileSizeAuthor
#7 webform_normal_view.png15.97 KBbalajidharma
#6 webform_size_issue.png32.33 KBbalajidharma
#2 webform-column-required-is-hidden-2662094-2.patch1.21 KBbalajidharma
Issue-webform.png412.02 KBk1m
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Kim VZ created an issue. See original summary.

balajidharma’s picture

balajidharma
Primary language English
CreditAttribution: balajidharma as a volunteer commented
Version: 7.x-4.12 » 7.x-4.x-dev
Status: Active » Needs review
FileSize
webform-column-required-is-hidden-2662094-2.patch1.21 KB
nicrodgers’s picture

nicrodgers
Primary language English
Location Monmouthshire, UK
CreditAttribution: nicrodgers at Welsh Government commented
Status: Needs review » Needs work

I've replicated the issue by following the steps in the summary, and can confirm the patch has applied successfully and fixes the issue.

However it looks like the patch also (accidentally?) includes an unrelated change to the size of the name field:

+++ b/includes/webform.components.inc
@@ -82,7 +82,7 @@ function webform_components_form($form, $form_state, $node) {
+    '#size' => 15,
balajidharma’s picture

balajidharma
Primary language English
CreditAttribution: balajidharma as a volunteer commented
Status: Needs work » Needs review

If name field size 30 means makes UI issue. So only i reduced size to 15.

nicrodgers’s picture

nicrodgers
Primary language English
Location Monmouthshire, UK
CreditAttribution: nicrodgers at Welsh Government commented
Status: Needs review » Needs work

Hi balajidharma, I think it'd be better to remove that change from the patch and create a new issue for the UI issue you describe, as it's not directly related to this. This will help prevent scope creep. See the issue scoping guidance here for more info https://www.drupal.org/core/scope

balajidharma’s picture

balajidharma
Primary language English
CreditAttribution: balajidharma as a volunteer commented
Status: Needs work » Needs review
FileSize
webform_size_issue.png32.33 KB

Hi Nic Rodgers,

For this issue i removed colspan for name field and added formkey field in webform components. Due to this changes name field take 30% size in table. So i reduced name field size.

webform size issue

webform_normal_view

Thanks,
Balaji D

balajidharma’s picture

balajidharma
Primary language English
CreditAttribution: balajidharma as a volunteer commented
FileSize
webform_normal_view.png15.97 KB
SocialNicheGuru’s picture

SocialNicheGuru CreditAttribution: SocialNicheGuru commented
Status: Needs review » Closed (duplicate)

this is a dupe of https://www.drupal.org/node/2649042 (the patches are almost identical)