Great module! Love that it doesn't leave me with a hot mess of nodes.
Just a small nit:
In the absence of the base path in Drupal.behaviors.selective_tweets_async_load I am unable to test in my local environment.
load('selective-tweets/feed/load/' + bid + '/0'...
should be
load(Drupal.settings.basePath + 'selective-tweets/feed/load/' + bid + '/0'...
and in selective_tweets_twitter_feed_build() (for good measure):
'#path' => 'selective-tweets/feed/load/' . $bid . '/' . (++$page) . '/nojs'
should be
'#path' => base_path() . 'selective-tweets/feed/load/' . $bid . '/' . (++$page) . '/nojs'
Dead simple patch to follow.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | selective_tweets-missing_base_path-2660884-3.patch | 628 bytes | fernly |
| #2 | selective_tweets-missing_base_path-2660884.patch | 1.67 KB | othermachines |
Comments
Comment #2
othermachines commentedComment #3
fernly commentedThanks! And good point.
Just had to undo the addition in
selective_tweets_twitter_feed_build()as the path is passed through theurl()function anyway intheme_link(). It actually causes it to break by adding the base path explicitly.If you agree upon the change, it'll be committed and available in dev soon.
Comment #4
othermachines commentedAhh, of course you're right. That would be terrific. Thanks!
Comment #6
fernly commentedCommitted patch #3 and available in current dev version.
@othermachines, notice that the current dev version got updated today due to some other feature requests as well. There are a few minor html structure changes but they can influence your theming. More information in the 'releases' part of the project page.
Comment #7
othermachines commentedThat's great. I'm still evaluating my options (non-production) so no worries on the changes, but I appreciate the heads up. Thanks!