See https://www.drupal.org/node/1210798 for background.

This issue only exists to backport the hack from 8.x so that tests pass on PHP 5.4+.

Comments

twistor created an issue. See original summary.

twistor’s picture

Status: Active » Needs review
StatusFileSize
new1.17 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2660744-1.patch, failed testing.

twistor’s picture

Status: Needs work » Needs review
StatusFileSize
new1.17 KB

Those failures don't make any sense.

David_Rothstein’s picture

Status: Needs review » Reviewed & tested by the community

I confirmed this is the same workaround that went into Drupal 8 via #2193023: EditorXssFilter/StandardTest::dataset #25 fails on php 5.4 so it looks good to go. (We can probably fix a couple minor things in the code comment on commit, "@fixme" => "@todo" and "its" => either "it's" or "it is".)

I'll mark #1210798: In PHP 5.4+, html_entity_decode() doesn't decode invalid numeric entities for Drupal 7 backport also.

David_Rothstein’s picture

StatusFileSize
new1.17 KB
new285 bytes

Just uploading the real patch plus a no-op patch to double check that the test failures are what we expect them to be (given the confusing results above).

fabianx’s picture

Issue tags: +Pending Drupal 7 commit

RTBC + 1, looks good to me.

Marking for commit.

  • stefan.r committed bbaf40b on 7.x
    Issue #2660744 by twistor: Skip test for decoding invalid numeric...
stefan.r’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: -Pending Drupal 7 commit

Committed and pushed to 7.x, thanks!

  • stefan.r committed 54ceb6a on 7.x
    Issue #2660744 by twistor: Skip test for decoding invalid numeric...
fabianx’s picture

Issue tags: +PHP 5.4

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.