Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
base system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
1 Feb 2016 at 23:25 UTC
Updated:
17 Jul 2016 at 13:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
twistor commentedComment #4
twistor commentedThose failures don't make any sense.
Comment #5
David_Rothstein commentedI confirmed this is the same workaround that went into Drupal 8 via #2193023: EditorXssFilter/StandardTest::dataset #25 fails on php 5.4 so it looks good to go. (We can probably fix a couple minor things in the code comment on commit, "@fixme" => "@todo" and "its" => either "it's" or "it is".)
I'll mark #1210798: In PHP 5.4+, html_entity_decode() doesn't decode invalid numeric entities for Drupal 7 backport also.
Comment #6
David_Rothstein commentedJust uploading the real patch plus a no-op patch to double check that the test failures are what we expect them to be (given the confusing results above).
Comment #7
fabianx commentedRTBC + 1, looks good to me.
Marking for commit.
Comment #9
stefan.r commentedCommitted and pushed to 7.x, thanks!
Comment #11
fabianx commented