Remove support for paths with %, provide validation and description for path

The way forward for the UI is pretty clear. But what should we do for pages that are programmatically defined? Or if we don't write an upgrade path? (Though we probably should!)

Do we throw an exception, trigger an error, skip it and use an assert()?

Here's a patch for the exception.

Fixed #8. Didn't include an upgrade path. Still not sure about the exceptions.

Uhhh, okay?

diff --git a/page_manager_ui/src/Form/PageFormBase.php b/page_manager_ui/src/Form/PageFormBase.php
index d089b5e..78c3793 100644
--- a/page_manager_ui/src/Form/PageFormBase.php
+++ b/page_manager_ui/src/Form/PageFormBase.php
@@ -108,10 +108,10 @@ public function validatePath(&$element, FormStateInterface $form_state) {
     $form_state->setValueForElement($element, $value);
 
     if (strpos($value, '%')) {
-      $form_state->setErrorByName('path', 'The entity path may not contain "%".');
+      $form_state->setErrorByName('path', 'The entity path may not contain %.');
     }
     if ($value === '/') {
-      $form_state->setErrorByName('path', 'The entity path may not be "/".');
+      $form_state->setErrorByName('path', 'The entity path may not be /.');
     }
 
     // Ensure each path is unique.
diff --git a/page_manager_ui/src/Tests/PageManagerAdminTest.php b/page_manager_ui/src/Tests/PageManagerAdminTest.php
index 6fa0159..a1ec058 100644
--- a/page_manager_ui/src/Tests/PageManagerAdminTest.php
+++ b/page_manager_ui/src/Tests/PageManagerAdminTest.php
@@ -367,7 +367,7 @@ protected function doTestAddPageWithSlashOnlyPath() {
       'path' => '/',
     ];
     $this->drupalPostForm('admin/structure/page_manager/add', $edit, 'Save');
-    $this->assertText('The entity path may not be "/".');
+    $this->assertText('The entity path may not be /.');
     $this->drupalGet('admin/structure/page_manager');
     $this->assertNoText('Bar');
   }
@@ -383,7 +383,7 @@ protected function doTestAddPageWithPercentInPath() {
       'path' => 'admin/%',
     ];
     $this->drupalPostForm('admin/structure/page_manager/add', $edit, 'Save');
-    $this->assertText('The entity path may not contain "%".');
+    $this->assertText('The entity path may not contain %.');
     $this->drupalGet('admin/structure/page_manager');
     $this->assertNoText('Bar');
   }

That would pass tests. What's so special about "?

Re-rolling patch.

Canceled

Re-rolling patch.

Page Manager 8.x-1.x is no longer supported, closing.