Proposal

Create drush install script to allow a user to automatically follow the steps required for setting up the basic theme. The following requirements must be met:

  • Script must be interactive and allow a user to "name" the theme
  • Must detect if npm is installed
  • Must detect if bower is installed
  • Run npm install
  • Run bower install
  • Rename appropriate references from "basic" to new theme "name" (files, functions, classes, styles, etc)
CommentFileSizeAuthor
#6 basic-drush_script_docs.patch2.38 KBleahtard
#3 basic-drush_install_script-2659588-3.patch7.1 KBmark.labrecque

Comments

SteveK created an issue. See original summary.

mark.labrecque’s picture

mark.labrecque
he/him
Primary language English
Location Vancouver
commented
Assigned: SteveK » mark.labrecque
mark.labrecque’s picture

mark.labrecque
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new basic-drush_install_script-2659588-3.patch7.1 KB
mark.labrecque’s picture

mark.labrecque
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
leahtard’s picture

leahtard commented

Thanks for the group effort mark.labrecque, SteveK and joelpittet! Here is what I experienced:

1. Downloaded and enabled the Basic theme -- this step was required first.
2. In terminal run: $ drush basic-install
3. The script checked that I had npm and bower installed on my machine
4. I was asked to provide a Name and machine name for my new theme
5. The basic folder was duplicated and all applicable files were renamed in my new theme folder -- fantastic!

@TODO's
1. Add some notes to the readme file -- I can take this on
2. There is some code that is currently commented out in basic.drush.inc. Is this remnants of a previous attempt or is this code that could potentially be useful for another iteration?

Cheers, Leah

leahtard’s picture

leahtard commented
StatusFileSize
new basic-drush_script_docs.patch2.38 KB

Updated docs patch attached :)

  • mark.labrecque authored 8e6b41c on 8.x-1.x 
    Issue #2659588 by mark.labrecque, SteveK, joelpittet: Create drush...
leahtard’s picture

leahtard commented

Patches have been applied.

Cheers, Leah

mark.labrecque’s picture

mark.labrecque
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new basic-drush_install_script-2659588-9.patch2.98 KB

Here is a patch to address some cruft and unused code. Also corrects some of the comment formatting.

  • mark.labrecque authored f6f02b5 on 8.x-1.x 
    Issue #2659588 by mark.labrecque, leahtard, SteveK: Create drush install...
CatherineOmega’s picture

CatherineOmega commented

Works like a dream. Well done, everyone.

leahtard’s picture

leahtard commented
Status: Needs review » Fixed

This went out in the 8.x-1.1 re;ease today. Great work everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.