[meta] Drupal 8 port of Social feed

I've tried my hand at porting this module ad I've pushed my changes up to GitHub.

https://github.com/afraazali/social_feed

There's a few other things to do, primarily tests and exception handling.

Frosev, Thanks for this! I'm trying your version and I might be pushing back some changes as I'm trying to pull in social feeds on the d8 site right now.

Thanks Josh,

Let me know if you come across any issues.

Thanks frosev, I'm also testing this module.

I think there are a couple of bugs displaying post dates in the facebook feed.

1. Formatting the post date isn't working, I'm not sure why yet. Line 42 of social_feed.theme.inc

$post['created_time'] = $formatted_date->format(Drupal::config('social_feed.facbeooksettings')->get('time_format'));

2. The condition to display the post date markup in the facebook template looks like it is using an incorrect variable name. I think Line 25 of social-feed-facebook-post.html.twig should be

{% if should_display_time %}

not

{% if shouldDisplayTime %}

Those are the bugs I've noticed so far, just testing facebook.

Do you have any idea how to request or access larger images for each facebook post. At the moment there is a max width/height of 130px for each image.

Another bug in social_feed.theme.inc line 24, the facebook URL is missing double slashes.

return Link::fromTextAndUrl($hash[0], Url::fromUri('https:facebook.com/hashtag/' . $hash[1], array('attributes' => array('target' => '_blank'))))->toString();

Wouldn't it be better to create instances, of say the Facebook feed block, and be able to configure it to a specific page and app. That way you can have multiple feeds from different Facebook pages across your site? Having the one configuration per social source seems kind of limiting.

Thanks for the feedback. I'll take a look at the bugs. To answer @anthorn305 comment, I was thinking the same thing, but I made this a straight port of the existing D7 site for an existing project, but I'll definitely take a look at making it a derivative block, so that multiple blocks can be generated.

Great Job frosev

Could the maintainer merge frosev work so we can upload fixes and enhancements in patches.

We really need this module and we may help to make it stable.

Regards