Instead of requiring a separate update hook to enable ctools, we can just enable it directly in the update hook.

If the module is missing, Drupal throws an exception aborting the update in Drush. update.php won't even let updates start until ctools is present, so I think we're covered there.

CommentFileSizeAuthor
#3 2657750.2-pathauto-enable-ctools.patch679 bytesdeviantintegral
#2 2657750.1-pathauto-enable-ctools.patch660 bytesdeviantintegral

Comments

deviantintegral created an issue. See original summary.

deviantintegral’s picture

deviantintegral commented
Status: Active » Needs review
StatusFileSize
new 2657750.1-pathauto-enable-ctools.patch660 bytes
deviantintegral’s picture

deviantintegral commented
StatusFileSize
new 2657750.2-pathauto-enable-ctools.patch679 bytes

Whoops, that was against the alpha release.

The last submitted patch, 2: 2657750.1-pathauto-enable-ctools.patch, failed testing.

The last submitted patch, 2: 2657750.1-pathauto-enable-ctools.patch, failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Reviewed & tested by the community
berdir’s picture

berdir
Primary language German
Location Switzerland
commented

How badly does this explode if ctools is *not* on the filestem? Maybe we should catch exceptions an in case of an exception, assume that the module is missing and re-throw with this explanation?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Not worse than it does now I guess.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.