Hi
I realise this issue has come up before, and I have tried every possible JSON format described in the following issues but we are still having problems with this. We are unable to PUT an image into the "Picture" field.
https://www.drupal.org/node/1309844
https://www.drupal.org/node/2061225
https://www.drupal.org/node/2424199

So steps to reproduce.

  • We already have an image in the drupal system that we are using.
  • We are using the user update form.
  • We are using PUT not POST.
  • We are using JSON.
  • All other fields are edited without issue.
  • But the picture never works.
  • We have tried many different suggestions as shown in the 3 above issues, including naming picture or picture_upload.
  • However the field is always empty.

So the problem I think is due to the picture_upload expecting to be an object, but via JSON this always ends up in the $account variable as an array. Consequently it fails.

So I'm proposing 2 fixes for this. Both of which I have written but I want the maintainers input into this before I upload them.

Patch 1. Simply checks if picture_upload is an array and if so turns it into an object. This is good but the difficulty here is that the JSON would have to be populated with the entire file object which the source providing the JSON may not have.

or

Patch 2. Propose a variable in the JSON called "picture_fid"

  • If the picture_upload is already populated then it is ignored.
  • Otherwise it will take the picture_fid if it exists, return the file object with file_load and populate picture_upload with it..

If I have missed something here and this is not a problem then could someone please let me know how to assign an image to this field with JSON.

Thanks

CommentFileSizeAuthor
#4 picture_uploadfix-2657380-4.patch1.24 KBDrupalChimp
#2 picture_uploadfix-2657380-1.patch1.26 KBDrupalChimp

Comments

DrupalChimp created an issue. See original summary.

DrupalChimp’s picture

DrupalChimp commented
StatusFileSize
new picture_uploadfix-2657380-1.patch1.26 KB

Ok, So I have submitted this patch. It basically allows you to upload a fid as string or int. or the full file object as an object/array in the JSON.

So examples would be

{
  "picture_upload": 22
}

{
  "picture_upload": "22"
}

{
  "picture_upload": {
    "fid": "22"
    "uid": "7",
     "filename": "picture-7.png",
     etc....
  }
}
kylebrowning’s picture

kylebrowning commented
Status: Active » Needs review

I like the patch in #2

DrupalChimp’s picture

DrupalChimp commented
StatusFileSize
new picture_uploadfix-2657380-4.patch1.24 KB

Made a mistake.

DrupalChimp’s picture

DrupalChimp commented
Version: 7.x-3.12 » 7.x-3.x-dev
kylebrowning’s picture

kylebrowning commented
Status: Needs review » Reviewed & tested by the community

  • marcingy committed 0ab84f0 on 7.x-3.x authored by DrupalChimp 
    Issue #2657380 by DrupalChimp: Unable to upload user picture on user...
marcingy’s picture

marcingy commented
Status: Reviewed & tested by the community » Fixed

Merged thanks

JMTorres’s picture

JMTorres commented

This commit breaks my site on any page that loads user_resource.inc with:

"PHP message: PHP Fatal error: Can't use function return value in write context in .../sites/all/modules/services/resources/user_resource.inc on line 400"

According to http://php.net/manual/en/function.empty.php , empty() only supports variables prior to PHP 5.5.

Automated testing should be enabled for the project on drupal.org to catch these types of issues.

JMTorres’s picture

JMTorres commented
Priority: Major » Critical
Status: Fixed » Needs work

kylebrowning’s picture

kylebrowning commented
Status: Needs work » Fixed

Fixed in DEV!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.