https://example.com/us/login_one_time/20855/1453833742/KjYIgsiUEwzzZXdgUedsCgbowPpFiTbYGWOhks7zH9k
Notice: Undefined index: destination in login_one_time_get_action_path() (line 789 of login_one_time/login_one_time.module).
CommentFileSizeAuthor
#3 coding_standards_errors.txt8.58 KBbapi_22
#2 notice_undefined-2657190-2.patch1.67 KBjoelpittet

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
StatusFileSize
new notice_undefined-2657190-2.patch1.67 KB

Noticed $action was always going home if destination is empty, so defaulted that.

bapi_22’s picture

bapi_22 commented
Status: Needs review » Needs work
StatusFileSize
new coding_standards_errors.txt8.58 KB

Hi @joelpittet ,

Thanks for the patch. Can you please looking into the standards as per attached file.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Needs review

Thank you for reviewing the patch although those standards should be fixed, my patch doesn't introduce those standards issues and they should be fixed in a separate issue. Can you post a coding standards issue please?

  • joelpittet authored e6a9fcd on 7.x-2.x 
    Issue #2657190 by joelpittet, bapi_22: Notice: Undefined index:...
bapi_22’s picture

bapi_22 commented
Status: Needs review » Fixed

Great job @joelpittet. Commited. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.