Thanks for making the module.

I use D8 Editor Advanced link together with D8 Editor File upload and sometimes it doesn't work, it just says "Loading" when I click the button. Other times the GUI appears, but seems to be lacking some CSS... (see the image)

I am getting this notice in the logs:

Notice: Undefined index: #group in editor_advanced_link_form_editor_link_dialog_alter() (line 82 af /data/www/website/modules/editor_advanced_link/editor_advanced_link.module).
Notice: Undefined index: #group in editor_advanced_link_form_editor_link_dialog_alter() (line 82 af /data/www/website/modules/editor_advanced_link/editor_advanced_link.module).

I use Bootstrap, and there has been a previously issue, where users just get a "Loading" message when clicking the image icon, perhaps this issue is related? Editor routes don't use the ajax_base_page theme negotiator

GUI

CommentFileSizeAuthor
Selection_002.png20.32 KBraj45

Comments

raj45 created an issue. See original summary.

raj45’s picture

Issue summary: View changes
raj45’s picture

Issue summary: View changes
duaelfr’s picture

Version: 8.x-1.0 » 8.x-1.x-dev
Status: Active » Fixed
Related issues: +#2640086: Editor routes don't use the ajax_base_page theme negotiator

Thank you very much for the pointer.
That's now fixed in dev version and that's going to be released under 8.x-1.1.

duaelfr’s picture

Project: Editor Advanced link » Editor File upload
raj45’s picture

I can confirm that it now works with the official release of D8 Editor file upload, version 8.x-1.1. Thanks for fixing it very quickly, @DuaelFr!

wim leers’s picture

Awesome collaboration here :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

raj45’s picture