We need a better coverage of the UI/form elements for Commerce entities Admin/UI tests.
Ex. Tests do not check for the expected fields - product variation prices were hidden, and no test failed

CommentFileSizeAuthor
#6 order_admin_tests-2656222-6.patch4.6 KBvasike
#5 product_admin_tests-2656222-5.patch7.4 KBvasike
#4 product_admin_tests-2656222-4.patch7.4 KBvasike
#3 product_admin_tests-2656222-2.patch7.44 KBvasike

Comments

vasike created an issue. See original summary.

vasike’s picture

vasike
Location Ramnicu Valcea
commented
Status: Active » Needs review

There is a first patch for Product Admin tests:
- Test the form/field elements exists for product and variation IEF
- New method for edit a product page/form.

vasike’s picture

vasike
Location Ramnicu Valcea
commented
StatusFileSize
new product_admin_tests-2656222-2.patch7.44 KB

forgot the patch

vasike’s picture

vasike
Location Ramnicu Valcea
commented
StatusFileSize
new product_admin_tests-2656222-4.patch7.4 KB

Update the previous patch, remove t() function for test messages.

vasike’s picture

vasike
Location Ramnicu Valcea
commented
StatusFileSize
new product_admin_tests-2656222-5.patch7.4 KB

hmm, it seems the previous patch was not ok (extra bracket left)
new patch here (& delete the previous).

vasike’s picture

vasike
Location Ramnicu Valcea
commented
StatusFileSize
new order_admin_tests-2656222-6.patch4.6 KB

and here is patch for the Order Admin/UI tests.
Updates from existing tests:
- Test the form/field elements exists for order and line item IEF.
- Test the edit line item.

vasike’s picture

vasike
Location Ramnicu Valcea
commented

New patch for Store Order Admin/UI tests.
It seems was pretty broken.
There are several mandatory fields in the add/edit form, so actually the stores weren't save from UI.
This patch should "save" the saving from UI.

Updates:
- Test the form/field elements exists for store edit form.
- Add values for all mandatory fields, including for the store address.

vasike’s picture

vasike
Location Ramnicu Valcea
commented

it seems i didn't upload the patch for store.
Re-work and make a PR for this.
https://github.com/drupalcommerce/commerce/pull/314
I'll move the other patches for product and order to this PR.

vasike’s picture

vasike
Location Ramnicu Valcea
commented

Updated the PR with the other patches (commits) for product and order.

  • bojanz committed 854656d on authored by vasike 
    Issue #2656222 by vasike: Improve test for Commerce entities UI/admin
bojanz’s picture

bojanz commented
Status: Needs review » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.