Remove file_entity_entity_base_field_info()

Uploading a new patch that applies to the latest version. This patch also adds a default configuration to enable path alias field on install/update

Now the patch...

Fixing test

Indeed there's an issue with the patch.
Before fixing it I would like to understand your pov @Berdir. By default, an URL alias field is added if pathauto exits, so I just tried to keep the same behavior. Do you mean that this behavior should change?

About your "step further" I believe you're referring to the hook_update, right?

Addressing @Berdir feedback

The patch applies although when running the database update 8201, it generates the following errors:

Entity queries must explicitly set whether the query should be access checked or not. See Drupal\Core\Entity\Query\QueryInterface::accessCheck().

If accessCheck(TRUE) is inserted into the relevant query in the file_entity.install file, then the update runs fine:

/**
 * Update pathauto to enable path field for file entity type if there are
 * file aliases or patterns.
 */
function file_entity_update_8201() {
  if (\Drupal::moduleHandler()->moduleExists('pathauto')) {
    $file_patterns = \Drupal::entityTypeManager()->getStorage('pathauto_pattern')->loadByProperties(['type' => 'canonical_entities:file']);
    $file_aliases = \Drupal::entityTypeManager()->getStorage('path_alias')->getQuery()->condition('path', '/file/%', 'LIKE')->accessCheck(TRUE)->count()->execute();
    if (!empty($file_patterns) || $file_aliases > 0) {
      $config_factory = \Drupal::configFactory();
      $config = $config_factory->getEditable('pathauto.settings');
      $enabled_entity_types = $config->get('enabled_entity_types');
      $config->set('enabled_entity_types', array_unique(array_merge($enabled_entity_types, ['file'])));
      $config->save();
    }
    else {
      \Drupal::messenger()->addMessage(t("Files no longer have an alias field by default, enable it in the pathauto settings if you wish to use that."));
    }
  }
}

Updated patch attached

+++ b/file_entity.install
@@ -197,3 +197,24 @@ function file_entity_update_8005() {
+    $file_patterns = \Drupal::entityTypeManager()->getStorage('pathauto_pattern')->loadByProperties(['type' => 'canonical_entities:file']);
+    $file_aliases = \Drupal::entityTypeManager()->getStorage('path_alias')->getQuery()->condition('path', '/file/%', 'LIKE')->accessCheck(TRUE)->count()->execute();

You'd actually want ->accessCheck(FALSE)

Because you don't want the access checking enabled for this query.

Updated the patch addressing #23. Please review

Review so far:
I grepped all Drupal 8 projects using grep . xnddx . ru , currently only the file_entity is using this api function name .

It's likely a safe change to make above, thanks for your work.

@berdir, are you ok with this change?

Tested patch on #25 and it worked as hoped.

Gitlab didn't use the commit message I specified, grumble.

Should have been this:
git commit -m 'Issue #2655844 by rutiolma, bharath-kondeti, Berdir, robcarr, joseph.olstad, Steven Jones, c_archer: Remove file_entity_entity_base_field_info()' --author="Sascha Grossenbacher <5019-berdir@users.noreply.drupalcode.org>"

Included in rc2

I'm not sure if it's best to start a new issue or use this one, but after upgrading to RC2 and running the database updates, I'm noticing the following:

ENTITY/FIELD DEFINITIONS
Mismatched entity and/or field definitions
The following changes were detected in the entity type and field definitions.
File
The URL alias field needs to be uninstalled.

This was the only update I applied, so I don't see how this error could've come from anywhere else.

I tried uninstalling this module and reinstalling it (after running Cron), and the same for pathauto, but I can't seem to get rid of this message.

I have the same issue as @webdrips after updating to rc2

reverting this, a new release to follow

Thanks for reporting the issues, it is reverted in rc4

https://www.drupal.org/project/file_entity/releases/8.x-2.0-rc4

RC4 Removed the Status Report error message for me.

RC4 added it back for me, this patch removed it.

@webdrips I wonder if you want a URL alias field on your files? Maybe we need to be smarter about when the base field is declared, are you also using the latest versions of pathauto?