Because we don't have tests for image handling, #2655582: Notice: Undefined variable: val in DrupalTextMetaTag->getValue() cropped up. So write some.

CommentFileSizeAuthor
#7 metatag-n2655614-7.patch15.54 KBdamienmckenna
#6 metatag-n2655614-5.patch13.28 KBdamienmckenna
#5 metatag-n2655614-5.patch13.28 KBdamienmckenna
#4 metatag-n2655614-4.patch10.86 KBdamienmckenna
#3 metatag-n2655614-3.patch7.34 KBdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2655192: Plan for Metatag 7.x-1.11 release
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new metatag-n2655614-3.patch7.34 KB

Some initial tests for adding images of different types to the global configuration.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n2655614-4.patch10.86 KB

This now also tests image fields on a node.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n2655614-5.patch13.28 KB

This adds tests for confirming how multi-value images work when the meta tag only supports one value.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n2655614-5.patch13.28 KB

This tests the og:image meta tag with multiple images.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n2655614-7.patch15.54 KB

No, *this* file has the multiple-image handling.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

  • DamienMcKenna committed 23e4d18 on 7.x-1.x 
    Issue #2655614 by DamienMcKenna: Added tests for image handling.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.