The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.#1308326: PHP strict warning when using panels in Views which was committed and is in 6.x-3.11 fixes the compatibility with Views with this:
- function options_submit($form, &$form_state) {
+ function options_submit(&$form, &$form_state) {
Unfortunately, the fix in Views itself does the opposite in this RTBC issue: #2411093: PHP strict warnings: Declaration of ... should be compatible with ...
So if someone has patched their views for the PHP compatibility and then updates Panels, the PHP compatibility in here breaks it again.
I'll be attaching a patch that needs to be applied to remove the & once that patch is committed (or for anyone who is using it).
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | panels-declaration-compatibility-views-6-x-2-x-2654582-9-d6.patch | 692 bytes | osopolar |
| #2 | panels_views-declaration-compatibility_2654582-2.patch | 715 bytes | michelle |
Comments
Comment #2
michelleHere's the patch.
Comment #3
damienmckennaAnother one X-) RTBC.
Comment #4
japerryhrm, maybe this will get committed down the line.. but most likely not. Leaving it as the last issue for d6.
Comment #6
japerryActually, fixed in head. We'll roll a release when views is updated.
Comment #7
michelleThanks!
Comment #9
osopolarThis works for views 6.x-3.x, see http://cgit.drupalcode.org/views/tree/plugins/views_plugin_row_fields.in... but not forr views 6.x-2.x, see http://cgit.drupalcode.org/views/tree/plugins/views_plugin_row_fields.in....
Patch is for people using views 6.x-2.x.