Not sure exactly what we need, but need to get this unblocked soon so that we can move issues to Drupal.org.

https://www.drupal.org/pift-ci-job/146346

CommentFileSizeAuthor
#4 pathauto-assert-url-2653630-4.patch733 bytesberdir

Comments

Dave Reid created an issue. See original summary.

dave reid’s picture

Priority: Normal » Major
berdir’s picture

That's just a dependency problem. We need a more recent version of token. And for some weird reason that I don't understand, testbot checks out tagged releases, not dev snapshots.

See #2621644: Always use latest dev of dependencies. Will try to bump that again.

Releasing a new token alpha will help I hope but sometimes testbot is also slow in picking up new tagged versions. I was hoping to have the token tree/render cache stuff there done so we don't have further changes in that area but it's not quite there yet. But we should do that asap anyway.

berdir’s picture

Status: Active » Needs review
StatusFileSize
new733 bytes

So, that finally works. There's one strange test fail due to the sub-folder but it seems that should work, might be a core bug. This fixes it.

Status: Needs review » Needs work

The last submitted patch, 4: pathauto-assert-url-2653630-4.patch, failed testing.

The last submitted patch, 4: pathauto-assert-url-2653630-4.patch, failed testing.

The last submitted patch, 4: pathauto-assert-url-2653630-4.patch, failed testing.

The last submitted patch, 4: pathauto-assert-url-2653630-4.patch, failed testing.

berdir’s picture

Status: Needs work » Fixed

Committed. I'll disable sqlite and postgresql patch testing for now until we've figured out what's causing those test fails. Doesn't seem like a release blocking thing.

  • Berdir committed abd0eea on 8.x-1.x
    Issue #2653630 by Berdir: Fix failing tests
    
dave reid’s picture

I would like to leave PHP 5.5 enabled on issues please. Testing min + max PHP seems like a good idea for all patches that are submitted.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.