Problem/Motivation

As now, there is no validation for customer/primary account keys for Drupal 7 version.

Proposed resolution

Implement validation in translator settings form. While doing this we can update replace "Microsoft Customer ID" with "Client ID" and "Primary Account Key" with "Client secret" same as it is in D8.

CommentFileSizeAuthor
#11 ms_trans_ui.png60.27 KBmbovan
#9 microsoft_ui_d7.png17.25 KBmbovan
#4 validate_client_id_and-2653286-4-interdiff.txt1.9 KBmbovan
#4 validate_client_id_and-2653286-4.patch4.99 KBmbovan
#2 validate_client_id_and-2653286-2.patch4.11 KBmbovan

Comments

mbovan created an issue. See original summary.

mbovan’s picture

mbovan commented
Status: Active » Needs review
StatusFileSize
new validate_client_id_and-2653286-2.patch4.11 KB

Added validation, tests and updated description of API keys fields.

Status: Needs review » Needs work

The last submitted patch, 2: validate_client_id_and-2653286-2.patch, failed testing.

mbovan’s picture

mbovan commented
Status: Needs work » Needs review
StatusFileSize
new validate_client_id_and-2653286-4.patch4.99 KB
new validate_client_id_and-2653286-4-interdiff.txt1.9 KB

Test bot is complaining about missing tmgmt_translator_load()...

Status: Needs review » Needs work

The last submitted patch, 4: validate_client_id_and-2653286-4.patch, failed testing.

The last submitted patch, 4: validate_client_id_and-2653286-4.patch, failed testing.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

Since we changed the naming of these keys already multiple times, i like to see a screenshot of the M$ UI with the proper naming of these keys.
(of course, wipe out the effektive key values.. ;-) )

The last submitted patch, 4: validate_client_id_and-2653286-4.patch, failed testing.

mbovan’s picture

mbovan commented
Status: Needs work » Needs review
StatusFileSize
new microsoft_ui_d7.png17.25 KB

Here is the screenshot of Microsoft translator's user interface.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

Thx for sending. I was more referring to the Microsoft side UI where the keys are created (sure with unreadable secrets ;-) ) to compare

mbovan’s picture

mbovan commented
Issue summary: View changes
StatusFileSize
new ms_trans_ui.png60.27 KB

Here is the another one:

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

Looks consistent! Hope we didn't swap them. ;-)

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

What exactly is the difference between this and #2655952: Add "Connect" button ?

mbovan’s picture

mbovan commented

D7 and D8 version? In D7 we don't have parent::addConnectButton() or?

  • Berdir committed be62059 on 7.x-1.x authored by mbovan 
    Issue #2653286 by mbovan: Validate client ID and secret keys
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Uh, forget what I said :)

Wow, took me 15m+ to figure out again how to set this up. Super confusing. I thought we once improved the docs on what to do, did we only do that for 8.x?

We should also finally remove the old API key field.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.