Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
As now, there is no validation for customer/primary account keys for Drupal 7 version.
Proposed resolution
Implement validation in translator settings form. While doing this we can update replace "Microsoft Customer ID" with "Client ID" and "Primary Account Key" with "Client secret" same as it is in D8.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | ms_trans_ui.png | 60.27 KB | mbovan |
| #9 | microsoft_ui_d7.png | 17.25 KB | mbovan |
| #4 | validate_client_id_and-2653286-4-interdiff.txt | 1.9 KB | mbovan |
| #4 | validate_client_id_and-2653286-4.patch | 4.99 KB | mbovan |
| |||
| #2 | validate_client_id_and-2653286-2.patch | 4.11 KB | mbovan |
| |||
Comments
Comment #2
mbovan CreditAttribution: mbovan at MD Systems GmbH commentedAdded validation, tests and updated description of API keys fields.
Comment #4
mbovan CreditAttribution: mbovan at MD Systems GmbH commentedTest bot is complaining about missing
tmgmt_translator_load()...Comment #7
miro_dietikerSince we changed the naming of these keys already multiple times, i like to see a screenshot of the M$ UI with the proper naming of these keys.
(of course, wipe out the effektive key values.. ;-) )
Comment #9
mbovan CreditAttribution: mbovan at MD Systems GmbH commentedHere is the screenshot of Microsoft translator's user interface.
Comment #10
miro_dietikerThx for sending. I was more referring to the Microsoft side UI where the keys are created (sure with unreadable secrets ;-) ) to compare
Comment #11
mbovan CreditAttribution: mbovan at MD Systems GmbH commentedHere is the another one:
Comment #12
miro_dietikerLooks consistent! Hope we didn't swap them. ;-)
Comment #13
BerdirWhat exactly is the difference between this and #2655952: Add "Connect" button ?
Comment #14
mbovan CreditAttribution: mbovan at MD Systems GmbH commentedD7 and D8 version? In D7 we don't have parent::addConnectButton() or?
Comment #16
BerdirUh, forget what I said :)
Wow, took me 15m+ to figure out again how to set this up. Super confusing. I thought we once improved the docs on what to do, did we only do that for 8.x?
We should also finally remove the old API key field.