After update to Metatag 7.x-1.8: "Undefined variable: entity_name in metatag_update_7101"

$entity_name really does not exist but $entity_type does... ( or any other things in $entity_info array)

CommentFileSizeAuthor
#5 metatag-n2652772-5.patch2.34 KBdamienmckenna

Comments

fox mulder created an issue. See original summary.

fox mulder’s picture

fox mulder commented

...consequently, 'metatag:ENTITYTYPE:BUNDLE:tag' records in {locales_source} are not updated with 'metatag:metatag_config:ENTITYTYPE:BUNDLE:tag'

This can cause this maybe related issue: https://www.drupal.org/node/2652120

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Priority: Normal » Critical
Parent issue: » #2649840: Plan for Metatag 7.x-1.9 release

Oh fudge.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Bumped this to Critical because it doesn't fix a data problem that 1.8 was supposed to fix.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new metatag-n2652772-5.patch2.34 KB

Does this fix the issue for you?

fox mulder’s picture

fox mulder commented

thanks it did

what does your "Oh fudge" mean here? My english and the english to hungarian google translation are not too sophisticated

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

@fox: Thanks for the review!

The "oh fudge" statement was just a bit of polite swearing :)

  • DamienMcKenna committed 48605f7 on 7.x-1.x 
    Issue #2652772 by DamienMcKenna: Fix update 7101 and rerun it to correct...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

fox mulder’s picture

fox mulder commented

thanks for the quick help!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.