Problem/Motivation

We can extend demo content and add OHT module into the list of supported translators as we have D8 version now.

Proposed resolution

Add OHT translator in the node created in tmgmt_demo_install().

CommentFileSizeAuthor
#4 update_demo_module_with-2652604-4-interdiff.txt8.17 KBmbovan
#4 update_demo_module_with-2652604-4.patch8.01 KBmbovan
#2 update_demo_module_with-2652604-2.patch985 bytesmbovan

Comments

mbovan created an issue. See original summary.

mbovan’s picture

mbovan commented
Status: Active » Needs review
StatusFileSize
new update_demo_module_with-2652604-2.patch985 bytes

Fixed.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work 
+++ b/modules/demo/tmgmt_demo.install
@@ -74,6 +74,7 @@ function tmgmt_demo_install() {
         .       '<li>' . t('<a href="@microsoft">Microsoft Translator</a>', ['@microsoft' => Url::fromUri('https://www.drupal.org/project/tmgmt_microsoft')->toString()]) . '</li>'
         .       '<li>' . t('<a href="@google_translate">Google translate</a>', ['@google_translate' => Url::fromUri('https://www.drupal.org/project/tmgmt_google')->toString()]) . '</li>'
         .       '<li>' . t('<a href="@gengo">Gengo</a>', ['@gengo' => Url::fromUri('https://www.drupal.org/project/tmgmt_mygengo')->toString()]) . '</li>'
+        .       '<li>' . t('<a href="@oht">OneHourTranslation</a>', ['@oht' => Url::fromUri('https://www.drupal.org/project/tmgmt_oht')->toString()]) . '</li>'

links should use :oht, lets fix those while touching this.

mbovan’s picture

mbovan commented
Status: Needs work » Needs review
StatusFileSize
new update_demo_module_with-2652604-4.patch8.01 KB
new update_demo_module_with-2652604-4-interdiff.txt8.17 KB

Updated links with :placeholder.

Also, #2646596: Should not be possible to review a completed task was fixed so we can remove it from the content.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed

Committed, but changed OneHourTranslation to One Hour Translation.
While not all occurences are consistent, it seems to be their preferred writing now.
https://www.onehourtranslation.com/translation/about-us

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.