Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
i Installed the latest Version (8.x-1.0-beta4) on an Drupal 8.0.2 Installation.
Standart Theme - just some css work.
Popup is never showing up - test a few Browsers. Nothing.
I dont know exactly where i should start looking at.
Any advice ?
Comments
Comment #2
vodde83 CreditAttribution: vodde83 commentedI had the same issue.
However, in eu_cookie_compliance.module , I changed this ( line #57 ):
$geoip_match = false;
to :
$geoip_match = true;
And then it started working.
I also had to check "Enable popup" in /admin/config/system/eu-cookie-compliance , but you probably found that out already.
Comment #3
fholzer CreditAttribution: fholzer commented@vodde83
i tryed this - but it didnt worked.
BUT - i have google analytics with geoip enabled - so i thought you could be right.
did you do something else ?
for testing Purpose i disabled the geoip from googly analytics - no effect.
Comment #4
fholzer CreditAttribution: fholzer commentedi made an failure, i forgot to clear the cache (drupal) - after clearing it - it works.
So basically Vodde83 was right.
After Changing to
$geoip_match = true;
its working.
I think its related to Google Analytics Module.
did you have Google Analytics installed ?
Comment #5
vodde83 CreditAttribution: vodde83 commentedNo I didn't. But I noticed this in line #59 :
if (!empty($config->get('popup_enabled')) && \Drupal::currentUser()->hasPermission('display EU Cookie Compliance popup') && $geoip_match && $domain_allow && !$path_match) {
It clearly says
" .. && $geoip_match "
, so the check assumes that$geoip_match = true
But if that is hard-coded to
false
, obviously the rest of the function won't trigger.Hence, the pop-up won't appear.
The
$geoip_match
variable probably needs to be set based on some logic of the GeoIP / SmartIP modules , as they were supported in the Drupal 7 version.But the required logic just isn't ported yet to the Drupal 8 version, so for now it seems that the variable was just hard-coded for the time being.
Comment #6
killua99 CreditAttribution: killua99 as a volunteer commentedI'll check this.
Comment #8
killua99 CreditAttribution: killua99 as a volunteer commentedI just commit a hotfix.
This will need some work for the next Beta.
Comment #9
killua99 CreditAttribution: killua99 as a volunteer commentedPlease test the latest dev version.
Even tho there's no information about dev version, use drush or composer or drupal console to download the module in dev version.
Comment #10
fholzer CreditAttribution: fholzer commentedEverything working fine with the latest Commit (7652af4)
ty killua99
Comment #11
asrobYes, 8.x-1.x-dev is working with Drupal 8.0.3.
Comment #12
killua99 CreditAttribution: killua99 as a volunteer commentedComment #14
danquah CreditAttribution: danquah at Reload commentedJust used an hour trying to get beta4 to work before I found this bug. It would be really nice if we could have a beta 5 with at least this bug fixed as there is really no point of having beta4 out there with no chance of working :)