i Installed the latest Version (8.x-1.0-beta4) on an Drupal 8.0.2 Installation.
Standart Theme - just some css work.

Popup is never showing up - test a few Browsers. Nothing.
I dont know exactly where i should start looking at.

Any advice ?

Comments

fholzer created an issue. See original summary.

vodde83’s picture

I had the same issue.
However, in eu_cookie_compliance.module , I changed this ( line #57 ):
$geoip_match = false;
to :
$geoip_match = true;

And then it started working.
I also had to check "Enable popup" in /admin/config/system/eu-cookie-compliance , but you probably found that out already.

fholzer’s picture

@vodde83

i tryed this - but it didnt worked.
BUT - i have google analytics with geoip enabled - so i thought you could be right.
did you do something else ?

for testing Purpose i disabled the geoip from googly analytics - no effect.

fholzer’s picture

i made an failure, i forgot to clear the cache (drupal) - after clearing it - it works.
So basically Vodde83 was right.

After Changing to $geoip_match = true;
its working.

I think its related to Google Analytics Module.

did you have Google Analytics installed ?

vodde83’s picture

No I didn't. But I noticed this in line #59 :
if (!empty($config->get('popup_enabled')) && \Drupal::currentUser()->hasPermission('display EU Cookie Compliance popup') && $geoip_match && $domain_allow && !$path_match) {

It clearly says " .. && $geoip_match " , so the check assumes that $geoip_match = true
But if that is hard-coded to false , obviously the rest of the function won't trigger.
Hence, the pop-up won't appear.

The $geoip_match variable probably needs to be set based on some logic of the GeoIP / SmartIP modules , as they were supported in the Drupal 7 version.
But the required logic just isn't ported yet to the Drupal 8 version, so for now it seems that the variable was just hard-coded for the time being.

killua99’s picture

Version: 8.x-1.0-beta4 » 8.x-1.x-dev
Status: Active » Needs work

I'll check this.

  • killua99 committed 40d32b3 on 8.x-1.x
    Issue #2651392: Popup not showing up
    
killua99’s picture

Status: Needs work » Needs review

I just commit a hotfix.

This will need some work for the next Beta.

killua99’s picture

Please test the latest dev version.

Even tho there's no information about dev version, use drush or composer or drupal console to download the module in dev version.

fholzer’s picture

Everything working fine with the latest Commit (7652af4)

ty killua99

asrob’s picture

Status: Needs review » Reviewed & tested by the community

Yes, 8.x-1.x-dev is working with Drupal 8.0.3.

killua99’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: +ecc_tag-beta5

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

danquah’s picture

Just used an hour trying to get beta4 to work before I found this bug. It would be really nice if we could have a beta 5 with at least this bug fixed as there is really no point of having beta4 out there with no chance of working :)