Translator Information wrapper open by default when the job is not finished

Translator info should always be open I think if displayed. The only thing we could think about is have it closed by default when the job is finished. But there's usually not a lot of information in there, so I wouldn't worry about that. It's possibly not even collapsible in 7.x but detail elements always are?

When doing my most recent presentation, i realised a completed job looks strange when editing. You only see collapsed elements.
I'm not so sure about this practice. Whatever i did, i needed to click on a collapsed item...

I don't think that's what miro said? (He said its strange that everything is closed for completed jobs, you keep it like that).

As discussed, I think we should keep this always open or even switch to a non-collapsible fieldset for some cases. Not sure. But definitely always open. Also the job items and messages IMHO.

+++ b/src/Form/JobForm.php
@@ -315,7 +315,7 @@ class JobForm extends TmgmtFormBase {
         '#title' => t('Translator information'),
-        '#open' => FALSE,
+        '#open' => TRUE,
         '#weight' => 20,

@@ -338,7 +338,7 @@ class JobForm extends TmgmtFormBase {
         '#title' => $view->storage->label(),
-        '#open' => FALSE,
+        '#open' => TRUE,

Possibly those two should stay closed for new jobs. That's the one place where especially messages aren't interesting as there are none yet.

+++ b/src/Form/JobForm.php
@@ -182,7 +182,7 @@ class JobForm extends TmgmtFormBase {
         '#title' => t('Job items'),
-        '#open' => $job->getState() == Job::STATE_ACTIVE,
+        '#open' => TRUE,
         '#weight' => 10,

The idea is that job items are only shown for active jobs.

Note that even configuration changes like this is something that we need to consider update functions. Existing sites will not get them automatically.

In this case, I can live with existing installations not having that, so committed. it would be different if it would be critical functionality.