@media screen and (max-width: 37.5em) { /* 600px */
  th.priority-low,
  td.priority-low,
  th.priority-medium,
  td.priority-medium {
    display: none;
  }
}
@media screen and (max-width: 60em) { /* 920px */
  th.priority-low,
  td.priority-low {
    display: none;
  }
}

.priority-low always gets overridden by the next css rule.

CommentFileSizeAuthor
#34 Screenshot.PNG73.09 KBgaurav-mathur
#30 Screenshot from 2022-07-26 13-02-59.png81.61 KBanjali_jha
#26 Screenshot from 2021-10-21 12-53-10.png182.25 KBvikashsoni
#12 table-3.png215.41 KBmanjit.singh
#12 table-2.png163.06 KBmanjit.singh
#12 table-1.png169.88 KBmanjit.singh
#9 after_patch.png137.76 KBcstpraveen
#10 before_patch.png138.08 KBcstpraveen
#9 before_patch.png132.34 KBcstpraveen
#8 after_seven.png431.66 KBdarketaine
#8 before_seven.png477.91 KBdarketaine
#4 after_patch.png382.14 KBdarketaine
#4 before_patch.png391.63 KBdarketaine
#4 full_width.png117.19 KBdarketaine
#2 bartik-2650032-2.patch447 byteschi

Issue fork drupal-2650032

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Issue fork bartik-2650032

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Chi created an issue. See original summary.

chi’s picture

chi commented
Status: Active » Needs review
StatusFileSize
new bartik-2650032-2.patch447 bytes
emma.maria’s picture

emma.maria
she/her
commented
Title: Remove unused selectors from Bartik's table.css » Code refactor: Remove unused selectors from Bartik's table.css
Version: 8.0.x-dev » 8.1.x-dev
Category: Bug report » Task
Issue tags: +frontend, +CSS, +Novice, +Needs screenshots

The next task is to review and double check that we definitely do not need these styles and also add screenshots to show the component before and after.

darketaine’s picture

darketaine commented
StatusFileSize
new full_width.png117.19 KB
new before_patch.png391.63 KB
new after_patch.png382.14 KB

It seems fine (which makes sense).

I see that Seven has the same CSS. Should we change that too (in this issue)?

chi’s picture

chi commented

@darketaine, I would create followup issue for this.

johnmcc’s picture

johnmcc commented
Status: Needs review » Reviewed & tested by the community

The patch applies correctly to 8.1.x. I agree, it shouldn't cause any issues (and indeed, that seems to be the case.) +1 RTBC.

emma.maria’s picture

emma.maria
she/her
commented
Status: Reviewed & tested by the community » Needs review
Issue tags: -Needs screenshots

The block of CSS code in question for this issue was originally added as part of the responsive tables solution here #1276908: Administrative tables are too wide for smaller screens.

Has anyone explored into why this code exists in the first place? It looks like it needs to stay intact. Plus Seven still has this code also.

darketaine’s picture

darketaine commented
StatusFileSize
new before_seven.png477.91 KB
new after_seven.png431.66 KB

This part of code seems to be a direct copy from Seven after this issue #1800304: The css for responsive tables on bartik contains old class names with no further investigation at that time.

So the key question is why Seven has it. I removed it from Seven too and it seems fine (I include screenshots of that too with the related media queries), which makes sense as no other media query overrides it. Even with grep I couldn't find something that could cause a conflict.

Maybe it was first in reverse order (first the (max-width: 60em) media query and then the (max-width: 37.5em)) and then a mobile-first logic was decided and this code was forgotten like this?

cstpraveen’s picture

cstpraveen commented
Issue tags: +ChennaiDrupalGroup
StatusFileSize
new before_patch.png132.34 KB
new after_patch.png137.76 KB

The patch works fine.

cstpraveen’s picture

cstpraveen commented
StatusFileSize
new before_patch.png138.08 KB
cstpraveen’s picture

cstpraveen commented
manjit.singh’s picture

manjit.singh
Primary language Hindi
Location Chandigarh
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new table-1.png169.88 KB
new table-2.png163.06 KB
new table-3.png215.41 KB

Good to go :) Couple of screenshots of tables.

After:

table issue

table issue

There is a issue in responsive on admin/structure/block but it is not relevant to this issue.

table issue

darketaine’s picture

darketaine commented
Status: Reviewed & tested by the community » Needs review

Let's wait for @emma.maria to see it further and decide if it's RTBC as there were already screenshots but needed more info. :)

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

emma.maria’s picture

emma.maria
she/her
commented
Issue tags: -Novice

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

vikashsoni’s picture

vikashsoni commented
StatusFileSize
new Screenshot from 2021-10-21 12-53-10.png182.25 KB

@Chi I thing there is no issue exists like this for ref sharing screenhost

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Shyam_Bhatt made their first commit to this issue’s fork.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

anjali_jha’s picture

anjali_jha commented
StatusFileSize
new Screenshot from 2022-07-26 13-02-59.png81.61 KB
anjali_jha’s picture

anjali_jha commented

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

gaurav-mathur’s picture

gaurav-mathur commented
Assigned: Unassigned » gaurav-mathur
gaurav-mathur’s picture

gaurav-mathur commented
Assigned: gaurav-mathur » Unassigned
StatusFileSize
new Screenshot.PNG73.09 KB

I have checked the issue without applying patch.I am unable to get the issue.
I checked issue in drupal 10.1.x-dev version with using Bartik theme.
For refer attached screenshot.

andy-blum’s picture

andy-blum
he/him/his
Primary language English
Location Ohio, USA
commented
Project: Drupal core » Bartik
Version: 10.1.x-dev » 1.0.2
Component: Bartik theme » Look and Feel

Bartik has been removed from core. Moving this issue to the contrib project.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 1.0.2 » 1.0.x-dev
Status: Needs review » Needs work

Please put the patch into an issue fork of Bartik and merge request.

angel_devoeted made their first commit to this issue’s fork.

angel_devoeted changed the visibility of the branch 2650032-code-refactor-remove to hidden.

angel_devoeted opened merge request !17

angel_devoeted’s picture

angel_devoeted commented
Status: Needs work » Needs review