Problem/Motivation

On the modules page due to size of field_info_fields() and a large number of modules. I've got around 379 active modules.

Proposed resolution

Static cache for the same result. Doesn't need to be reset so don't need drupal_static()

Remaining tasks

User interface changes

API changes

Data model changes

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new953 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 2649906-2.patch, failed testing.

The last submitted patch, 2: 2649906-2.patch, failed testing.

The last submitted patch, 2: 2649906-2.patch, failed testing.

The last submitted patch, 2: 2649906-2.patch, failed testing.

joelpittet’s picture

Well I guess we need drupal_static() for the test to reset it. I'm trying to track down the real problem I think it's Rules + Commerce discount. But I think this would be good to have still.

deciphered’s picture

I can confirm that using drupal_static() resolves the issue with the tests, but can you please provide some more information about how you actually performed the profiling as I'm only vaguely familiar with XHProf.

You mention that the result is On the modules page, but that seems unusual as that function shouldn't be triggering at that point in time.

joelpittet’s picture

From testing, features rebuilding in that page, I think that's triggering rules config rebuild, and rules is/was building commerce discounts entities which have field attach calls.

Xhprof allows me to dig into the function calls and I did a run comparison.

Sorry sounds not great, on phone.

voleger’s picture

Status: Needs work » Closed (outdated)

Drupal 7 reached EOL

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.