Problem/Motivation

Now submitting a task to local translator with user assigned by submitter doesn't have test coverage, so we should add it.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 interdiff-add_test_assign_task-2649522-2-5.txt1.21 KBedurenye
#5 add_test_assign_task-2649522-5.patch2.32 KBedurenye
#2 add_test_assign_task-2649522-2.patch1.86 KBedurenye
#2 add_test_assign_task-2649522-2-test_only.patch1.13 KBedurenye
#2 add_test_assign_task-2649522-2.png52.12 KBedurenye

Comments

edurenye created an issue. See original summary.

edurenye’s picture

edurenye commented
Issue summary: View changes
Status: Active » Needs review
Related issues: +#1946308: Add support for job_comment for LUI
StatusFileSize
new add_test_assign_task-2649522-2.png52.12 KB
new add_test_assign_task-2649522-2-test_only.patch1.13 KB
new add_test_assign_task-2649522-2.patch1.86 KB

I had a failing test when submitting the job through the UI with a comment on in, it was deleted, so I fixed, this feature was added in this issue #1946308: Add support for job_comment for LUI but was not added in the form.

UI change:

The last submitted patch, 2: add_test_assign_task-2649522-2-test_only.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work 
  1. +++ b/translators/tmgmt_local/src/LocalTranslatorUi.php
@@ -35,6 +35,12 @@ class LocalTranslatorUi extends TranslatorPluginUiBase {
+      '#title' => t('Comment for the translation'),
+      '#description' => t('You can provide a comment so that the translator will better understand your requirements.'),

    not sure about the comment here, especially the requirements thing. Do we do something similar in e.g. tmgmt_oht? 

  2. +++ b/translators/tmgmt_local/src/Tests/LocalTranslatorTest.php
@@ -244,7 +244,17 @@ class LocalTranslatorTest extends TMGMTTestBase {
 
-    $job->requestTranslation();
+    // Test assign task while submitting job.
+    $edit = ['settings[translator]' => $this->localTranslator->id()];
+    $this->drupalPostForm(NULL, $edit, t('Submit to translator'));

    Please change the test by actually filling out the comment form instead of assigning the comment through the API above.

edurenye’s picture

edurenye commented
Status: Needs work » Needs review
StatusFileSize
new add_test_assign_task-2649522-5.patch2.32 KB
new interdiff-add_test_assign_task-2649522-2-5.txt1.21 KB

Done the second point.
About the point 1, yes, actually I get the message from tmgmt_oht.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Title: Add test assign task while submitting job » Add test assign task and provide a comment while submitting job
Version: 8.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Patch (to be ported)

Thanks, committed.

  • Berdir committed fb5055a on 8.x-1.x authored by edurenye 
    Issue #2649522 by edurenye: Add test assign task and provide a comment...