Problem/Motivation

From #2647976: Update monitoring when changing past event severity: we need to fix MonitoringSearchAPITest. Maybe they renamed a method or something there.
Also MonitoringDemoTest is broken (due to search_api). The config structure of the index there changed, we need to update that.

Proposed resolution

Fix it.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 update_MonitoringSearchAPITests-2648174-7.patch2.58 KBtduong
#7 interdiff-2648174-3-7.txt714 bytestduong
#3 update_MonitoringSearchAPITests-2648174-3.patch2.4 KBtduong
#2 update_MonitoringSearchAPITest-2648174-2.patch1.69 KBtduong

Comments

tduong created an issue. See original summary.

tduong’s picture

tduong commented
Status: Active » Needs review
StatusFileSize
new update_MonitoringSearchAPITest-2648174-2.patch1.69 KB
tduong’s picture

tduong commented
StatusFileSize
new update_MonitoringSearchAPITests-2648174-3.patch2.4 KB

Missing search_api.index.demo.yml changes.

tduong’s picture

tduong commented
Issue summary: View changes

Status: Needs review » Needs work

The last submitted patch, 3: update_MonitoringSearchAPITests-2648174-3.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented 
+++ b/src/Tests/MonitoringSearchAPITest.php
@@ -55,7 +55,7 @@ class MonitoringSearchAPITest extends MonitoringUnitTestBase {
     // @todo Remove workaround for outdated SearchAPI Version on testbot.
     if (\Drupal::hasService('search_api.index_task_manager')) {
-      Utility::getIndexTaskManager()
+      \Drupal::service('search_api.index_task_manager')
         ->addItemsAll(Index::load('database_search_index'));
     }

We should be able to remove the if + @todo now, just always call it. Testbot is using the latest version as well now.

tduong’s picture

tduong commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2648174-3-7.txt714 bytes
new update_MonitoringSearchAPITests-2648174-7.patch2.58 KB

Removed if + todo. There is still something odd with MonitoringCoreKernelTest: $xpath (line 287) is an empty array and I'm not sure what was that test about. Do you have any idea how to fix it?

Status: Needs review » Needs work

The last submitted patch, 7: update_MonitoringSearchAPITests-2648174-7.patch, failed testing.

tduong’s picture

tduong commented

Created an issue for this failing test: #2649414: Fix MonitoringCoreKernelTest::testImageMissingStyleSensorPlugin.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Fixed

Committed.

  • Berdir committed 7a766ee on 8.x-1.x authored by tduong 
    Issue #2648174 by tduong: Update MonitoringSearchAPITest

The last submitted patch, 2: update_MonitoringSearchAPITest-2648174-2.patch, failed testing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.