Problem/Motivation

In admin/tmgmt/sources we use status icons, we can reuse those icons to display better the status of the local translation tasks items.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#10 Screenshot from 2016-01-21 15:05:20.png14.45 KBjohnchque
#10 add_status_icons_to_the_local_translation_task-2648146-10.patch8.3 KBjohnchque
#10 interdiff-2648146-8-10.txt3.9 KBjohnchque
#8 Screenshot from 2016-01-21 12:21:09.png15.41 KBjohnchque
#8 add_status_icons_to_the_local_translation_task-2648146-8.patch5.23 KBjohnchque
#8 interdiff-2648146-5-8.txt3.58 KBjohnchque
#5 Screenshot from 2016-01-20 14:52:03.png10.53 KBjohnchque
#5 Screenshot from 2016-01-20 14:43:12.png15.53 KBjohnchque
#5 add_status_icons_to_the_local_translation_task-2648146-5.patch4.33 KBjohnchque
#5 interdiff-2648146-2-5.txt2.65 KBjohnchque
#2 add_status_icons_to_the_local_translation_task-2648146-2.patch3.96 KBjohnchque

Comments

edurenye created an issue. See original summary.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Active » Needs review
StatusFileSize
new add_status_icons_to_the_local_translation_task-2648146-2.patch3.96 KB

Added icons to the local translation task items. Still not sure about what icons use in some states though. We should add icons for the next states:
- Translation Rejected, needs implementation in #2647992: [meta] Add feedback loop and commenting items to local translator
- Translation Completed (Different from Translated)
We were thinking to implement icons for the job items too. In that case we should add (or define) icons for the following states:
- Active
- Review
- Accepted
- Aborted
Still need to add tests.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work
Issue tags: +Needs screenshots

When working on tasks that change the UI, always post before/after screenshots, so it can be reviewed quickly.

edurenye’s picture

edurenye commented
Parent issue: #2559353: Port local translator to Drupal 8 »
Related issues: +#2559353: Port local translator to Drupal 8
johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2648146-2-5.txt2.65 KB
new add_status_icons_to_the_local_translation_task-2648146-5.patch4.33 KB
new Screenshot from 2016-01-20 14:43:12.png15.53 KB
new Screenshot from 2016-01-20 14:52:03.png10.53 KB

Added changes, rebased. Added Screenshot for UI changes.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented

Still need to decide which icons use. Need some feedback to decide.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Needs work

I read "Translation Task Item status" that should be "Status" only, since each row is about a translation task item.

Untranslated can not be a sandwatch. A sandwatch means we are waiting for someone. Instead they wait for us!
Untranslated should be the orange triangle. It's the primary thing that needs action.
Rejected can be a red triangle (or even a red cross).
Translated can be the grey check.
Completed can be the green check.

That would be a solid start to iterate from.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2648146-5-8.txt3.58 KB
new add_status_icons_to_the_local_translation_task-2648146-8.patch5.23 KB
new Screenshot from 2016-01-21 12:21:09.png15.41 KB

Icons added based on comment #7. Added interdiff and screenshot of new icons.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Issue summary: View changes
Status: Needs review » Needs work

Yeah those icons make sense to me. :-)

Still plz rename the status column and since it wouldn't be the first time to see something like this broken, cover checking for some raw icon output with tests.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2648146-8-10.txt3.9 KB
new add_status_icons_to_the_local_translation_task-2648146-10.patch8.3 KB
new Screenshot from 2016-01-21 15:05:20.png14.45 KB

Changed column label to Status, added correct titles to icons. Fixed asserts for asserting the correct text. Interdiff added. Ui changes image added. Based on comment #9

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed
Issue tags: -Needs screenshots

Yeah, that looks good! Committed.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented

To be consistent with the UI, we should discuss if we will apply the admin theme on local translator. Since we have added icons on Job Items (#2650860: Add state icons to Job Items.) and they are using the admin theme they are aligned to the right and the ones we added here are not. The discussion is continued here: #2653470: Local translator theme

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.