Comments

urvigala created an issue. See original summary.

shruti.sheth’s picture

StatusFileSize
new0 bytes

Hi,
Please find the coding standards fixed patch here.

Thanks,
Shruti Sheth

shruti.sheth’s picture

StatusFileSize
new12.58 KB

Hi,
Please find the coding standards fixed patch here.

Thanks,
Shruti Sheth

shruti.sheth’s picture

StatusFileSize
new12.58 KB

Hi Urvi,
Sorry for the above two comments and file uploads with mismatch comment numbers, Please take this patch into consideration.

Sorry once again !

Thanks,
Shruti Sheth

nitesh pawar’s picture

Hello,

I would have really appreciated if you guys would have reported functional issues or blockers, but the issues that had been reported are related to coding standards to be precise identations, and these minor issues can be fixed by editor by configuring the drupal template.
It will be highly appreciated if you guys could report these kind of issues on drupal project application where it will be helpful for the new comers to understand the coding standards.

Thanks,
Nitesh

madhavvyas’s picture

+++ b/Direct/commerce_veritrans_direct.module
@@ -121,8 +118,14 @@ function commerce_veritrans_direct_submit_form($payment_method, $pane_values, $c
+function commerce_veritrans_direct_submit_form_validate($pane_values, $form_parents = array()) {

It should
@return bool
instead of
@return bool Returns bool value

nitin shirole’s picture

Status: Needs work » Needs review
StatusFileSize
new12.56 KB

Hi,

I have changed the @return bool Returns bool value to @return bool
Please review.

Thanks,
Nitin

nitesh pawar’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.