Closed (fixed)
Project:
Translation Management Tool
Version:
8.x-1.x-dev
Component:
Translator: Local
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
8 Jan 2016 at 09:53 UTC
Updated:
26 Jan 2016 at 18:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
edurenye commentedNot sure if this is the proper solution, or we should check if we can translate it, and show the link, and then in case we click assign it automatically to ourself. But I think is better to make the user assign it manually to himself to not get confused, but not sure.
Comment #3
miro_dietikerYeah that fix works. This issue is not about changing the workflow at all.
There are many ways to improve the whole UX of the local translator, most importantly guide the user through the whole process, but that's a followup.
I would still prefer two if()s or an early exit if no translator available.
Comment #4
miro_dietikerOops, in any case, use hasTranslator() to check if there is a translator!
Comment #5
edurenye commentedWe don't have hasTranslator() but we can use isUnassigned().
This affects this other issue #2646592: Fix duplicated task when saving local task, I have this error in the tests that I'm adding there.
Comment #6
miro_dietikerOh man, "getTranslator()" is about the account that translates... It clashes somehow withour usual getTranslator that is fetching the translator plugin from job / item...
Should we change this API to getAssignee() or so? If we have a more complex workflow (from translator to reviewer, ...) we will use the same property / getter.
I just wanted to commit as is with followup work, but we also need a failing test for this!
Comment #7
edurenye commentedYes, I agree. Assignee is a better name to not be mistaken with that. I'll open a followup for that.
Here is the test. I'll extend that test in this issue #2646592: Fix duplicated task when saving local task.
Comment #8
edurenye commentedIssue created for renaming translator to assignee #2648678: Use Assignee instead of translator in tmgmt_local
Comment #11
berdirOk, committed.