Problem/Motivation

Missing message when saving local task item.
And missing link to resource in message when saving local task.

Proposed resolution

Add the message

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 interdiff-missing_messages_with-2646550-2-8.txt3.6 KBedurenye
#8 missing_messages_with-2646550-8.patch3.2 KBedurenye
#2 missing_messages_with-2646550-2.patch3.4 KBedurenye
#2 missing_messages_with-2646550-2-completed.png29.71 KBedurenye
#2 missing_messages_with-2646550-2-save.png43.23 KBedurenye

Comments

edurenye created an issue. See original summary.

edurenye’s picture

edurenye commented
Assigned: Unassigned » edurenye
Status: Active » Needs review
StatusFileSize
new missing_messages_with-2646550-2-save.png43.23 KB
new missing_messages_with-2646550-2-completed.png29.71 KB
new missing_messages_with-2646550-2.patch3.4 KB

Added messages for local task item, I can't add them in local task, as most of the things there are wrong and will be solved in this issue #2646592: Fix duplicated task when saving local task.
So we can just fix what we have in this issue and add the message when saving the task in the other issue, or just wait for the other issue to be commited
Also I added tests.

Result for "save":

Result for "save as completed":

It should redirect to completed not closed I think, so this is a new issue.

edurenye’s picture

edurenye commented
Related issues: +#2646592: Fix duplicated task when saving local task
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

The other issue got in, so I guess this needs a reroll?

+++ b/translators/tmgmt_local/src/Tests/LocalTranslatorTest.php
@@ -351,6 +351,7 @@ class LocalTranslatorTest extends TMGMTTestBase {
     );
     $this->drupalPostForm(NULL, $edit, t('Save as completed'));
+    $this->assertText('The translation of ' . $first_task_item->label() . ' to ' . $job->getTargetLanguage()->getName() . ' is finished and can now be reviewed.');

who exactly sees this?

not sure about the can now be reviewed part, is that relevant for the translator?

edurenye’s picture

edurenye commented
Parent issue: #2559353: Port local translator to Drupal 8 »
Related issues: +#2559353: Port local translator to Drupal 8
edurenye’s picture

edurenye commented
Status: Needs work » Needs review

It doesn't need reroll, I just retested.
Maybe is not so relevant for the translator, but the message is set by JobItem, as usual. I just print the messages when we add translated data to the JobItem.
What I should do exactly?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

Discussed in person.

edurenye’s picture

edurenye commented
Status: Needs work » Needs review
StatusFileSize
new missing_messages_with-2646550-8.patch3.2 KB
new interdiff-missing_messages_with-2646550-2-8.txt3.6 KB

As discussed, I changed the saved message removing the success as can not be saved without success.
And changed the other message to just say that the item has been saved as completed, that's what is relevant for the user that made the translation.

  • Berdir committed 4b71644 on 8.x-1.x authored by edurenye 
    Issue #2646550 by edurenye: Missing messages with link to resource when...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Thanks, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.