Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
BlockDisplayVariant has logic for handling selection criteria, but this is the domain of page_manager's page_variant entity, not variant display plugins.
Proposed resolution
Delete the properties and defaults and update tests where applicable.
Remaining tasks
TODO
User interface changes
TODO
API changes
TODO
Data model changes
TODO
Comment | File | Size | Author |
---|---|---|---|
#5 | 2646286-ctools-5.patch | 11.99 KB | tim.plunkett |
| |||
#5 | interdiff.txt | 6.68 KB | tim.plunkett |
#2 | 2646286-2.patch | 6.34 KB | EclipseGc |
|
Comments
Comment #2
EclipseGc CreditAttribution: EclipseGc commentedOk, this removes some tests since our access method is now core's which already has test coverage, and generally cleans up stuff that was using this interface.
CTools, Page Manager and Layout Plugin tests are all passing with the exception of an error in layout_plugin for an unrelated ctools change.
Eclipse
Comment #3
dsnopekWalked through all these changes with EclipseGC and witnessed the tests passing. :-)
I'm +1 on this, but I'll leave it to @tim.plunkett to RTBC!
Comment #4
tim.plunkettYou need to say what version it will be removed in.
But that said, why not just remove it instead of waiting? We're in alpha after all...
Comment #5
tim.plunkettAnd honestly, you can just remove ConditionVariantTrait outright too. Sure, page_manager is using it, but wrongly. And I can easily fix it (page_manager will be broken after the CTools release anyway)
Comment #6
dsnopekRemoving the trait sounds great to me! RTBC +1 :-)
Comment #8
EclipseGc CreditAttribution: EclipseGc commentedDavid and I discussed tim's additional removals here and decided while ctools would ideally provide a trait and interface for this sort of behavior, theres are named wrong at this point, and the trait is inconsistent in how to does various things, so perhaps we'll try again later with something that's not variant specific.
Eclipse