The locale module has been marked as a dependency on this module.
However, no function from locale appears to be used. If this is indeed the case, the dependency can be removed.

Please confirm ?

CommentFileSizeAuthor
#6 remove_locale.patch1.15 KBalansaviolobo

Comments

alansaviolobo created an issue. See original summary.

cmak’s picture

cmak commented
Status: Active » Closed (works as designed)

Hi,

Locale module is a dependency. We have used country_get_list function in the install file to load all countries into the country selection field. Hope this helps.

Thanks.

alansaviolobo’s picture

alansaviolobo commented

country_get_list is defined in inc/locale.inc and not in locale.module.
This module would work even if locale was not enabled.

alansaviolobo’s picture

alansaviolobo commented
Status: Closed (works as designed) » Active
cmak’s picture

cmak commented

Hi,

In Locale module, that locale.inc is include. "country_get_list" function is used in inc/country_specific_nodes.admin.inc as well.
The dependency can be removed, but instead of that we will need to include the locale.inc file everywhere in the code.

Thanks.

alansaviolobo’s picture

alansaviolobo commented
Category: Support request » Task
Status: Active » Needs review
StatusFileSize
new remove_locale.patch1.15 KB

I believe this would solve the problem.

Status: Needs review » Needs work

The last submitted patch, 6: remove_locale.patch, failed testing.

The last submitted patch, 6: remove_locale.patch, failed testing.

  • cmak committed 1041b1d on 7.x-1.x authored by alansaviolobo 
    Issue #2645794 by alansaviolobo, cmak: locale not a dependency
cmak’s picture

cmak commented
Status: Needs work » Fixed

Hi,

I have manually included the required inc file wherever needed to avoid any errors during installation. +1 credit to you for pointing out this.

Thanks.

cmak’s picture

cmak commented
Status: Fixed » Closed (fixed)

Closing.