Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I should have caught this in October, but it all happened a bit fast.
On the Extend page /admin/modules
This module is described as:
Inline Form Errors > Enables inline form errors.
But that says nothing about the advantages of enabling this module.
I'd prefer something like:
Enabling inline form errors improves accessibility of web forms errors so that they meet WCAG 2.0 requirements.
Comment | File | Size | Author |
---|---|---|---|
#12 | Screen Shot 2016-03-07 at 6.38.48 PM.png | 138.75 KB | RavindraSingh |
#10 | inline_form_error_mod_desc-2644818-10.patch | 660 bytes | Anishnirmal |
#10 | after patch.JPG | 43.82 KB | Anishnirmal |
#6 | Screen Shot 2016-01-12 at 9.12.40 PM.png | 79.63 KB | mgifford |
#4 | Drupal_core-inline_form_errors_desc-2644818-4.patch | 913 bytes | nupur.lohokare |
Comments
Comment #2
mgiffordComment #3
nupur.lohokare CreditAttribution: nupur.lohokare as a volunteer and at Faichi Solutions Pvt Ltd commentedComment #4
nupur.lohokare CreditAttribution: nupur.lohokare as a volunteer and at Faichi Solutions Pvt Ltd commentedFound the module description mentioned, and changed the description as per your suggestion.
Please review.
Thanks,
Nupur
Comment #5
nupur.lohokare CreditAttribution: nupur.lohokare as a volunteer and at Faichi Solutions Pvt Ltd commentedComment #6
mgiffordSimple text addition. I think this is good to go.
Comment #7
alexpottOne issue is that the module breaks things at the moment. I think we need a module that works better before having such a tantalising description. Reading that why wouldn't you enable it?
Comment #8
mgiffordI suppose we could outline the outstanding problems with enabling the module.
Ultimately though, if they enable it, and it causes problems it can just be disabled. The question is if we should build in more of a warning.
Maybe something like:
'Enabling inline form errors improves accessibility of web forms errors so that they meet WCAG 2.0 requirements. Unfortunately, some functionality within Forms API may not work as desired. '
Comment #10
Anishnirmal CreditAttribution: Anishnirmal as a volunteer and at UniMity Solutions Pvt Limited commentedHi,
Module description has been changed as per the suggestion at #8. Please review
After Patch
Comment #11
Girish-jerk CreditAttribution: Girish-jerk at UniMity Solutions Pvt Limited commentedComment #12
RavindraSingh CreditAttribution: RavindraSingh as a volunteer and at Srijan | A Material+ Company commentedPatch is validated and fixed, Steps to tests:
Moving to RTBC.
Comment #13
Anishnirmal CreditAttribution: Anishnirmal as a volunteer and at UniMity Solutions Pvt Limited commentedComment #16
catchCommitted/pushed to 8.2.x and cherry-picked to 8.1.x. Thanks!