Closed (fixed)
Project:
Panels
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
4 Jan 2016 at 18:46 UTC
Updated:
25 Jan 2016 at 18:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
dsnopekThis should be the functional changes! I'm going to try the tests now and see if they need any updates.
We shouldn't commit this until after the next CTools release (which means committing just before we release Panels).
Comment #3
dsnopekAlright, I messed up the order in the last patch. But the tests caught it too! Here's an updated patch which also has all the tests passing for me locally.
Comment #4
dsnopekThe last patch didn't include the fix for the order of the arguments. This is really the right patch! :-)
Comment #5
dsnopekJust a note: We'll need to update this patch once #2636478: IPE shouldn't depend on Page Manager is merged, because that patch includes a hack around the problems in CTools that #2642786: Improve dependency injection in BlockDisplayVariant fixed. The patch here should also remove that hack.
Comment #6
dsnopekHere's an attempt to update this after #2636478: IPE shouldn't depend on Page Manager - it passes tests locally!
Comment #7
dsnopekCTools has been released - let's give this to the testbot!
Comment #11
dsnopekI have no idea why this is failing. :-/ It just says fatal error, but doesn't give the error, and locally the test passes fine.
Comment #12
dsnopekLet's try re-uploading this, just in case that helps?
Comment #14
dsnopekOoooh, crap! I think I understand why this is failing. PanelsTest depends on using Page Manager do a functional test of Panels, and Page Manager is broken until #2642840: Update page_manager for changes in CTools 3.0-alpha21 is committed. :-/ So, we need to commit that and do a Page Manager release before the Panels tests will pass...
Comment #15
dsnopekPage Manager has finally had it's release:
https://www.drupal.org/node/2647480
Trying the tests again. Come on testbot!
Comment #19
eclipsegc commentedOk, we sorted the page_manager dependency difficulties and this is passing now. Fixed
Eclipse