When browser window is resized to small width, there is top margin between body and admin toolbar.

CommentFileSizeAuthor
#7 remove_top_body_margin-2643544-6.patch1.07 KBpsebborn
#3 before.jpg9.9 KBsaurabh.dhariwal
#3 after.jpeg10.21 KBsaurabh.dhariwal
#3 Bootstrap-Remove_top_body_margin-2643544-3-D8.patch168.92 KBsaurabh.dhariwal
Screenshot from 2016-01-03 22:35:04.png60.9 KBfaizalluthfi

Comments

faizalluthfi created an issue. See original summary.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Title: Please remove body top margin on small browser window width » Remove top body margin from mobile
Component: User interface » CSS Overrides
Category: Feature request » Bug report
Issue tags: -admin toolbar

Patches are welcomed.

saurabh.dhariwal’s picture

saurabh.dhariwal commented
StatusFileSize
new Bootstrap-Remove_top_body_margin-2643544-3-D8.patch168.92 KB
new after.jpeg10.21 KB
new before.jpg9.9 KB

PFA patch for the same with attached screenshots.

I have incorporated changes in Body and header section.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Active » Needs work

Don't change the minified CSS files (as indicated by ./css/README.md). These are automatically compiled from starterkits/less/less/overrides.less by the maintainers.

psebborn’s picture

psebborn commented
Assigned: Unassigned » psebborn
psebborn’s picture

psebborn commented
Status: Needs work » Needs review

I've moved the margin-top into a media query from tablet view (as wider than that it should still have the top margin).

I moved the variable declarations for the media queries to the top of the file so I can use them in the body rule - would appreciate a review of this to see if it's done the right way :)

psebborn’s picture

psebborn commented
StatusFileSize
new remove_top_body_margin-2643544-6.patch1.07 KB
platinum1’s picture

platinum1 commented

Works on iOS devices. Don't have Android to test...

  • neardark committed ba93321 on 8.x-3.x authored by psebborn 
    Issue #2643544 by saurabh.dhariwal, psebborn: Remove top body margin...
neardark’s picture

neardark commented
Assigned: psebborn » Unassigned
Status: Needs review » Fixed

Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.