Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The Panels tests break with the latest -dev of CTools due to this change #2639526: Calling BlockDisplayVariant::setConfiguration() won't change results returned from plugin collections which cause the plugin collections to get initialized when setting configuration. The problem is that the plugin managers aren't injected - they're pulled off the container! Which makes it impossible to unit test any class that descends from BlockDisplayVariant.
So, we need to inject those plugin managers, and also, we need to set all the dependencies before calling the parent constructor so that they can be used in the configuration functions that are called by the parent constructor.
I'm marking this as a bug because it's breaking the Panels tests.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | ctools-blockdisplayvariant-dependencies-2642786-9.patch | 1.64 KB | dsnopek |
Comments
Comment #2
dsnopekHere's the patch! Apparently, someone (maybe even me?) made similar changes in the tests so that we could even test BlockDisplayVariant at all - this patch removes that because the same basic fix is part of BlockDisplayVariant itself now. :-)
Comment #3
dsnopekEr, crap, a 0 byte patch. :-/ Here's the real patch!
Comment #5
dsnopekComment #7
dsnopekThanks!
Comment #8
dsnopekEep! Actually, I messed this up a little bit - this was missing the change to
::create(). Sorry!Comment #9
dsnopekBah, apparently, I messed up more stuff than that. :-/ This actually works my manual testing. This is what we get for having unit tests for this but not functional tests!
Comment #10
EclipseGc CreditAttribution: EclipseGc at Acquia commented