Tokens not replaced in file/widget field descriptions

This will fail - moving to field system as well as it's not really a token problem, but rather a widget(base) problem.

And with fix - we'll need additional tests for the file field widget too to make sure that it works there (since I changed code in FileWidget too).

+++ b/core/modules/file/src/Plugin/Field/FieldWidget/FileWidget.php
@@ -119,7 +119,7 @@ protected function formMultipleElements(FieldItemListInterface $items, array &$f
 
     $title = $this->fieldDefinition->getLabel();
-    $description = FieldFilteredMarkup::create($this->fieldDefinition->getDescription());
+    $description = FieldFilteredMarkup::create(\Drupal::token()->replace($this->fieldDefinition->getDescription()));
 
     $elements = array();

What about a helper method on WidgetBase for this? getFilteredDescription() or something like that?

WidgetBase is abstract, so I think that's totally fine todo for 8.0.x even.

reroll + new method

+++ b/core/lib/Drupal/Core/Field/WidgetBase.php
@@ -567,4 +567,13 @@ protected function isDefaultValueWidget(FormStateInterface $form_state) {
+   * @return \Drupal\Core\Field\FieldFilteredMarkup
+   */

I think we still require a description for @return, even if it is as simple as this?

Yeah, lazy me :)

Great. Lets get this fixed.

Adding the protected method to the base class is something we can't do in a patch release.

Not 100% sure for a minor release either - for me I'd make the change but be prepared to roll back before tagging a stable release if it turns out someone added a method to a subclass with the same name. Pinged alexpott for a second opinion.

Once this is in 8.1.x it's backportable to 8.0.x without the protected method, or possibly with an underscore prefix and @internal note.

Talked to @xjm to confirm we're on the same page.

While we treat base classes as @api, adding a method to a base class is not an API change. It could theoretically break someone's code somewhere, but that's what minors are for.

If we do break someone's code before a release candidate, they can file a bug report and we can talk about it. Otherwise it's just an improvement for everyone else anyway.

However, it's an API addition to the base class, so we should add a change notice.

Here it is:
https://www.drupal.org/node/2668850

Patch didn't apply to 8.1.x due to entity_create() conversion, so re-rolled.

Tested #19 on local.
Screenshots are attached. Seems working fine for me.

Tested #19
+1 RTBC

I only did a straight re-roll so I think I'm OK to commit this to 8.1.x

For 8.0.x we either need to skip the change to the base class and inline that code, or make it _underscorePrefixed() and @internal with a note that it'll change in 8.1.x.

I'm marking this fixed against 8.1.x, if you want to work on a backport please re-open and move it to 8.0.x.

Thanks!
Published the CR https://www.drupal.org/node/2668850

Lets just go back to the patch from #7 then for the backport. No need to introduce this method here if it causes so many complications. Wasn't aware that we're so strict on that in 8.0.x.

Re-uploading that patch, didn't make any changes.

Didn't apply anymore, rerolled.

The original patch seems to be missing test coverage.

+++ b/core/modules/image/src/Tests/ImageFieldWidgetTest.php
@@ -27,9 +27,10 @@ public function testWidgetElement() {
+    $this->assertNoText('Image test on [site:name]');

At the very least we should be asserting for the expected text as well... $this->assertNoText() is very vulnerable to false positives.

Let's go back to having this fixed against 8.1.x, since 8.0.x is about to be EOL. Let's open a followup for fixing the test coverage.

Also retroactively downgrading; the committers agreed this is not a major issue. Thanks!