The grade based access update is broken (course_update_7135). It's because it sets the high range regardless of whether there was ever any grade based access set on the course. This causes the settings form to fail validation because the high range is filled in but the low isn't.
Attached a patch that adds a check to ensure there was a grade based access originally on the course before populating the range.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | grade_based_access-2642498-6.patch | 744 bytes | djdevin |
| #3 | course_grade_access_upgrade.patch | 1.26 KB | kyoder |
Comments
Comment #3
kyoder commentedMy first patch was wrong. The problem wasn't that the course_grade var wasn't being checked for empty, that was already happening (the source of the var was already being checked). The problem was that an empty string equates to 0 so it was passing the check. I've updated the patch to simply check that course_grade (via its source) is either not empty or equates to 0 as a string. In other words, I just put 0 inside quotes.
Comment #6
djdevinComment #7
djdevin