Replace deprecated usage of entity_create('file') with a direct call to File::create()

patch does not apply anymore. Rerolled the patch.
Although it does not contain my code and it looks good to go, So RTBC it

A few entity_create('file'); are missing - for example in core/modules/editor/src/Tests/EditorFileUsageTest.php

Replaced all the stuff.
Few more findings that I did

+++ b/core/modules/content_translation/src/Tests/ContentTranslationSyncImageTest.php
@@ -137,7 +138,7 @@ function testImageFieldSync() {
+      $file = File::create($field_values);

Used $this->container->get('entity_type.manager')->getStorage('file')->create($field_values); in Tests b/c we used the static functions before DI was not possible in procedural code.

Looks like the interdiff is a repeat of the patch, and ends in .patch, so I'm reviewing https://www.drupal.org/files/issues/2641588-7.patch

I'm split down the middle on whether to use the entity type service or Entity::create() in these issues. So here's my review:

The patch applies and gets all the occurrences but one remaining in FeedsEnclosure.php.

+++ b/core/modules/file/src/Tests/SaveTest.php
@@ -64,14 +64,14 @@ function testFileSave() {
     );
-    $uppercase_file = File::create($uppercase_values);
+    $uppercase_file = $this->container->get('entity_type.manager')->getStorage('file')->create($uppercase_values);
     file_put_contents($uppercase_file->getFileUri(), 'hello world');
     $violations = $uppercase_file->validate();
     $this->assertEqual(count($violations), 0, 'No violations when adding an URI with an existing filename in upper case.');
     $uppercase_file->save();
 
     // Ensure the database URI uniqueness constraint is triggered.
-    $uppercase_file_duplicate = File::create($uppercase_values);
+    $uppercase_file_duplicate = $this->container->get('entity_type.manager')->getStorage('file')->create($uppercase_values);
     file_put_contents($uppercase_file_duplicate->getFileUri(), 'hello world');

In places like this, if you're explicitly using the service to generate the entity more than once, you should get a reference to the entity storage once, and then call create() on that multiple times.

It's obvious in this place in the patch that this is the solution, since this bit is uninterrupted in the patch. But it might also be like this in other places, too that aren't so obvious.

If we make this change so that we get the service once and then generate multiple entities, *or* if we use Entity::create() instead, I'll RTBC. Just so you know. :-) I think the emphasis is on deprecating entity_load() rather than analyzing the code.

Also: Restarting the test.

#8, Agreed we should use the static method for consistency over all places. EntityType::create()
As per discussion with about #7 in one of the followup issue, we are now sticking with the static method in tests as well.
hiding #7 patch
Resetting test for #5

Looks like #5 failed testing. I just tried to patch it and it doesn't apply.

working on this.

Patch applies, successfully replaces entity_create('file').

RTBC.

Needs a re-roll.

Rerolled #13

Missed one:

FeedsEnclosure.php	
      $file = entity_create('file', [      [position 118:15]	

@Mile23 I haven't been able to locate the file you indicate and I made a recursive search to replace entity_create('file') and I haven't found any new.

Please could you check again?

I checked with my IDE and its fine, there's no occurance left. Thanks!

#19, I think its the feeds module FeedsEnclosure.php http://cgit.drupalcode.org/feeds/tree/src/FeedsEnclosure.php?h=8.x-3.x#n118

Needs another re-roll...

Rerolled #18.

Thanks for the reroll.

Patch applies, and my IDE says it deals with all occurrences of entity_create('file

RTBC.

Committed/pushed to 8.1.x, thanks!