Hi. I just tried out the module and made a few small changes, and added a cron backup feature.

The small fixes made were:
1. The table config wasn't being saved yet (The config is saved, but does not yet take effect)
2. The backup history tab was causing PHP errors when using a private files directory outside of root
3. Removed print_r debugging call on the tables form submission

The cron config now has it's own tab, and is very simple. It has a checkbox to enable cron backups, and an interval field for hours between backups.

Not sure if you want to merge this in or not, but I thought I'd pass along a patch.

CommentFileSizeAuthor
#4 backup_db_cron_scheduled_backups-4.patch7.59 KBclint.beacock
backup_db_cron_scheduled_backups-1.patch5.2 KBclint.beacock

Comments

clint.beacock created an issue. See original summary.

swim’s picture

swim commented
Status: Needs review » Needs work

Hey brother,

thanks heaps for taking the time to write and post this patch. Looks good so far; however the BackupDatabaseCronForm file seems to be missing from the diff.

clint.beacock’s picture

clint.beacock commented

Ahh, right you are. I'll try to get a proper patch up today or tomorrow.

clint.beacock’s picture

clint.beacock commented
StatusFileSize
new backup_db_cron_scheduled_backups-4.patch7.59 KB

New patch, with the missing BackupDatabaseCronForm file.

  • swim committed 3795bfb on 8.x-1.x authored by clint.beacock 
    Issue #2640320 by clint.beacock: Add Cron Backup Schedule, and other...
swim’s picture

swim commented
Status: Needs work » Fixed

Thanks again for taking the time to add this feature. Latest patch looks good, committed to dev =).

clint.beacock’s picture

clint.beacock commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.