BlockDisplayVariant uses plugin collections for the list of blocks and selection conditions. It implements a special getConfiguration() to mix the plugin collections' configuration into the main plugin configuration. However, it doesn't do the reverse on setConfiguration(), which means if you change a block configuration (for example) in setConfiguration() it won't actually change the list of blocks returned!

This is basically about making setConfiguration() to the same as we're already doing for getConfiguration().

This fixes tests on the page_manager wizard issue: #2550879: Use CTools Wizard API to add/edit Pages (and move plugin UI using PluginWizardInterface)

CommentFileSizeAuthor
#2 ctools-block-collection-2639526-2.patch833 bytesdsnopek
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dsnopek created an issue. See original summary.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Active » Needs review
FileSize
ctools-block-collection-2639526-2.patch833 bytes

Here's the patch!

Status: Needs review » Needs work

The last submitted patch, 2: ctools-block-collection-2639526-2.patch, failed testing.

EclipseGc’s picture

EclipseGc CreditAttribution: EclipseGc at Acquia commented
Status: Needs work » Fixed

Looks way better than what we have.

Fixed, let's get some tests around this at some point.

Eclipse

  • EclipseGc committed 58568a5 on 8.x-3.x authored by dsnopek 
    Issue #2639526 by dsnopek: Calling BlockDisplayVariant::setConfiguration...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.