Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
migration system
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
22 Dec 2015 at 12:50 UTC
Updated:
17 Feb 2016 at 18:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
dawehnerHere is just a patch so far
Comment #4
dawehnerHa
Comment #5
dawehnerComment #6
chx commentedBesides testing, the handbook needs upgrading with ample warning on how this actually does not import data.
Comment #7
dawehnerThere we go, now also with some form of test coverage.
Comment #8
edysmpAnother option without this patch is:
But I like the patch. It makes the DX a lot easier.
Comment #9
chx commentedYou can't; this patch skips stubbing -- this means phenaproxima was right when he said it's cleaner to call it no_stubbing
Comment #10
edysmpActually, after looking at the migration plugin, I don't think #8 is a possibility. Let's go with it.
Comment #11
benjy commentedWe already have "no_stub" which does the same thing in the destination, these two names could be easily confused, shall we make them the same?
Comment #12
chx commentedWell. I put them on the destination because I thought it's the destination which can determine it just can not be stubbed. But perhaps we do need both? Like, it is possible in general for a destination to be stubbed but in specifics we do not want so?
Comment #13
dawehnerYeah there might be references in tables which are just broken. I learned here: never trust a 3rd party source.
Comment #14
benjy commentedI think in general it makes sense for the destination to have the settings when you're talking about the current migration but dawehner's problem here is that he wants to allow broken/missing data from another migration that is referenced. I think renaming to no_stub the same as the destinations would be more consistent and then the patch here looks good.
Missing new line
Comment #15
dawehnerThank you for your comment/review. Here is the newline
Comment #16
chx commentedLet's do this.
Comment #17
benjy commentedI still think this would be better. Even if skip_stubbing is a better name, consistency is the most important bit for me.
Comment #18
heddnResponding to #17.
Comment #19
dawehnerNice, well I just care about getting this done.
Comment #20
catchCommitted/pushed to 8.1.x and cherry-picked to 8.0.x. Thanks!