My understanding is that when using the sass/less starterkits, the subtheme should be in charge of the overrides css (i.e. overrides.less) however it is always included.

CommentFileSizeAuthor
#3 bootstrap-subtheme-css-overrides-2637700-3.patch2.65 KBSut3kh
#2 bootstrap-subtheme-css-overrides-2637700-2.patch2.56 KBSut3kh

Comments

Sut3kh created an issue. See original summary.

Sut3kh’s picture

Sut3kh commented
Status: Active » Needs review
StatusFileSize
new bootstrap-subtheme-css-overrides-2637700-2.patch2.56 KB

Here is my best guess at how it should work

Sut3kh’s picture

Sut3kh commented
StatusFileSize
new bootstrap-subtheme-css-overrides-2637700-3.patch2.65 KB

on reflection, i guess this should switch on $provider->getPluginId() instead of the provider version.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs review » Needs work 
+++ b/src/Plugin/Alter/LibraryInfo.php
@@ -27,21 +27,24 @@ class LibraryInfo extends PluginBase implements AlterInterface {
       if ($assets = $provider->getAssets()) {

This is actually where the fix should be IMO. If it's the base provider (none), it should just return an empty array. The reason it's currently going through is because it's still adding empty "css" and "js" arrays IIRC.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Assigned: Unassigned » markhalliwell

Also, now that I think about it, I really don't think there should be a "fallback" provider (no other plugin in the base theme has this). It just adds complications, like this one, IMO. I'll work on this.

P.S. Thank you for the patch though!

  • markcarver committed 3638d7a on 8.x-3.x 
    Issue #2637700 by Sut3kh: overrides.min.css is included when using the...
markhalliwell’s picture

markhalliwell
Primary language English
commented
Version: 8.x-3.0-beta1 » 8.x-3.x-dev
Assigned: markhalliwell » Unassigned
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.