There are a few constants in image.module that are leftover from D7 (used to specify if image styles were defined in code or in db), that are no longer in use in D8.

Let's deprecate them for removal later in D9.

CommentFileSizeAuthor
#8 2637630-8.patch1.19 KBmondrake
#2 2637630-2.patch1007 bytesmondrake

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
StatusFileSize
new 2637630-2.patch1007 bytes
cilefen’s picture

cilefen commented
Status: Needs review » Reviewed & tested by the community

This makes sense to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue tags: +Needs change record

I've linked this to the relevant CR.

mondrake’s picture

mondrake
Location 🇮🇹
commented

Do we need a separate CR, or editing the existing one?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: -Needs change record

@mondrake discussed with @catch and removing the constants is not correct. It breaks semver as it is technically possible that a contrib module is still using them for something. Therefore we need to deprecate for 9.x and remove them when we get there.

I don't think we need a separate CR for this. Although we could update the CR attached already to mention that constants are now meaningless to core.

mondrake’s picture

mondrake
Location 🇮🇹
commented

CR updated, https://www.drupal.org/node/1820974/revisions/view/9222776/9222920

mondrake’s picture

mondrake
Location 🇮🇹
commented
Title: Remove unused constants from image.module » Deprecate unused constants in image.module
Issue summary: View changes
StatusFileSize
new 2637630-8.patch1.19 KB

Deprecation patch.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review
cilefen’s picture

cilefen commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 5b420ee and pushed to 8.1.x. Thanks!

  • alexpott committed 5b420ee on 8.1.x 
    Issue #2637630 by mondrake: Deprecate unused constants in image.module

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.