I ran Etsy's Phan (static analyzer) on Drupal 8 and am investigating the output. It pointed out that Form API's callback_batch_operation is using $this when not in an object context.

CommentFileSizeAuthor
#6 core-form_api_this_not_in_context-2637254-5.patch598 bytestvlooy
#2 core-form_api_this_not_in_context-2637254-1.patch594 bytestvlooy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tvlooy created an issue. See original summary.

tvlooy’s picture

tvlooy CreditAttribution: tvlooy at iO commented
FileSize
core-form_api_this_not_in_context-2637254-1.patch594 bytes
tvlooy’s picture

tvlooy CreditAttribution: tvlooy at iO commented

ps: if this is confirmed as a bug. Then this code is probably not under tests. I must admit that I'm not sure what callback_batch_operation exactly does, but if nobody is using it (nobody reported any problems before) maybe we should just delete the code instead of fixing it.

tvlooy’s picture

tvlooy CreditAttribution: tvlooy at iO commented
Status: Active » Needs review
JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Component: forms system » documentation
tvlooy’s picture

tvlooy CreditAttribution: tvlooy at iO commented
FileSize
core-form_api_this_not_in_context-2637254-5.patch598 bytes

Thanks Jeroen. So it's example code, that explains a lot :-)

Nevertheless the example is wrong. I just found out that Drupal::entityManager() is deprecated so I adjusted the patch.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and for Acquia commented
Status: Needs review » Reviewed & tested by the community

@tvlooy: *.api.php files are examples on how to use the api. Those files are not executed or tested.

The example was wrong and your patch fixes it.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

+1 Thanks! @borisson, thanks for the review too.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed d8b27e3 and pushed to 8.0.x and 8.1.x. Thanks!

  • alexpott committed d213335 on 8.1.x 
    Issue #2637254 by tvlooy: Form API using $this when not in object...

  • alexpott committed d8b27e3 on 
    Issue #2637254 by tvlooy: Form API using $this when not in object...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.