Avoid testing for relative link starting with // in shortcut module

I also agree with that. But if we want to add that, then this test would have to change into this anyway, I guess ;)

Hm, not sure I follow what you want to add?

This issue is created because it will start to fail if #2462279: Language prefix for custom menu link paths are saved but not used gets committed, because that would disallow paths starting with //. Right now, if you try to add a path like that (say for example //google.com) shortcut will get saved and try to point to the internal path _base_path_/google.com. So that future new bug fix will ensure the test coverage, I think.

To answer your question, I don't know how to improve the test in this issue. So to improve the test... we could check that the string '//' is not there, but that feels like it was not what you asked for.

Another way to improve it was to add "//alias" to the list of path we are not allowed to save, but that would unfortunately still not pass (that would pass if we committed #2462279: Language prefix for custom menu link paths are saved but not used).

I understand what you are asking for, but that would be covered by that future bug fix (which should rtbc after this lands). So, in a hopeful manner, I am changing the status back to "needs review". :)

Sorry if I misunderstood your request. :)

Well, because I initially did that, but was asked to create a seperate issue for this seemingly unrelated change to make it easier for commiters. :D

If it is fine by you, I am happy to include this fix in that issue